SK-1906 Improve debugging in connections

Author: skyflow-vivek

skyflow/utils/_utils.py

@@ -341,6 +341,11 @@ def parse_invoke_connection_response(api_response: requests.Response):
 
         if 'x-request-id' in api_response.headers:
             message += ' - request id: ' + api_response.headers['x-request-id']
+        
+        if 'error-from-client' in api_response.headers:
+            error_from_client = api_response.headers['error-from-client']
+            details = [{ "error_from_client": error_from_client }]
+            raise SkyflowError(message, status_code, details=details)
 
         raise SkyflowError(message, status_code)
 

skyflow/vault/controller/_connections.py

@@ -27,7 +27,7 @@ def invoke(self, request: InvokeConnectionRequest):
 
         invoke_connection_request.headers['sky-metadata'] = json.dumps(get_metrics())
 
-        log_info(SkyflowMessages.Info.INVOKE_CONNECTION_TRIGGERED, self.__vault_client.get_logger())
+        log_info(SkyflowMessages.Info.INVOKE_CONNECTION_TRIGGERED.value, self.__vault_client.get_logger())
 
         try:
             response = session.send(invoke_connection_request)
@@ -36,5 +36,6 @@ def invoke(self, request: InvokeConnectionRequest):
             return invoke_connection_response
 
         except Exception as e:
+            if isinstance(e, SkyflowError): raise e
             raise SkyflowError(SkyflowMessages.Error.INVOKE_CONNECTION_FAILED.value,
                                SkyflowMessages.ErrorCodes.SERVER_ERROR.value)

tests/vault/controller/test__connection.py

@@ -100,5 +100,25 @@ def test_invoke_request_error(self, mock_send):
         with self.assertRaises(SkyflowError) as context:
             self.connection.invoke(request)
         self.assertEqual(context.exception.message, SkyflowMessages.Error.INVOKE_CONNECTION_FAILED.value)
+        self.assertTrue(context.exception.details['error_from_client'])
 
+    @patch('requests.Session.send')
+    def test_invoke_request_error_from_client(self, mock_send):
+        mock_response = Mock()
+        mock_response.status_code = FAILURE_STATUS_CODE
+        mock_response.content = ERROR_RESPONSE_CONTENT
+        mock_response.headers = {'error-from-client': True}
+        mock_send.return_value = mock_response
+
+        request = InvokeConnectionRequest(
+            method=RequestMethod.POST,
+            body=VALID_BODY,
+            path_params=VALID_PATH_PARAMS,
+            headers=VALID_HEADERS,
+            query_params=VALID_QUERY_PARAMS
+        )
 
+        with self.assertRaises(SkyflowError) as context:
+            self.connection.invoke(request)
+        self.assertEqual(context.exception.message, SkyflowMessages.Error.INVOKE_CONNECTION_FAILED.value)
+        self.assertTrue(context.exception.details['error_from_client'])