Skip to content

Commit 48c5b7b

Browse files
SK-2522: fix unit tests
1 parent a306f16 commit 48c5b7b

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

tests/utils/validations/test__validations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def test_validate_credentials_with_expired_token(self):
116116
with patch('skyflow.service_account.is_expired', return_value=True):
117117
with self.assertRaises(SkyflowError) as context:
118118
validate_credentials(self.logger, credentials)
119-
self.assertEqual(context.exception.message, SkyflowMessages.Error.INVALID_CREDENTIALS_TOKEN.value)
119+
self.assertEqual(context.exception.message, SkyflowMessages.Error.EXPIRED_BEARER_TOKEN.value)
120120

121121
def test_validate_credentials_empty_credentials(self):
122122
credentials = {}

tests/vault/controller/test__connection.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,9 @@ def test_invoke_request_error(self, mock_send, mock_get_credentials):
131131

132132
mock_response = Mock()
133133
mock_response.status_code = FAILURE_STATUS_CODE
134-
mock_response.content = ERROR_RESPONSE_CONTENT
134+
mock_response.content = ERROR_RESPONSE_CONTENT.encode('utf-8') # Convert to bytes
135+
mock_response.headers = {"x-request-id": "test-request-id"}
136+
mock_response.raise_for_status.side_effect = requests.HTTPError("400 Error")
135137
mock_send.return_value = mock_response
136138

137139
request = InvokeConnectionRequest(
@@ -144,8 +146,10 @@ def test_invoke_request_error(self, mock_send, mock_get_credentials):
144146

145147
with self.assertRaises(SkyflowError) as context:
146148
self.connection.invoke(request)
147-
self.assertEqual(context.exception.message, SkyflowMessages.Error.RESPONSE_NOT_JSON.value.format(ERROR_RESPONSE_CONTENT))
148-
self.assertEqual(context.exception.http_code, 400)
149+
150+
self.assertEqual(context.exception.message, ERROR_RESPONSE_CONTENT)
151+
self.assertEqual(context.exception.http_code, FAILURE_STATUS_CODE)
152+
self.assertEqual(context.exception.request_id, "test-request-id")
149153

150154
@patch('skyflow.vault.controller._connections.get_credentials')
151155
@patch('requests.Session.send')

0 commit comments

Comments
 (0)