SK-2040: resolve pr comments

Author: saileshwar-skyflow

src/utils/logs/index.ts

@@ -9,6 +9,7 @@ const logs = {
         VALIDATING_VAULT_CONFIG: 'Validating vault config.',
         VALIDATING_CONNECTION_CONFIG: 'Validating connection config.',
         VAULT_CONTROLLER_INITIALIZED: 'Initialized vault controller with vault ID %s1.',
+        DETECT_CONTROLLER_INITIALIZED: 'Initialized detect controller with vault ID %s1.',
         CONNECTION_CONTROLLER_INITIALIZED: 'Intitialized connection controller with connection ID %s1.',
         vaultId_CONFIG_EXISTS: 'Vault config with vault ID %s1 already exists.',
         vaultId_CONFIG_DOES_NOT_EXIST: `Vault config with vault ID %s1 doesn't exist.`,

src/utils/validations/index.ts

@@ -21,6 +21,7 @@ import TokenizeRequest from "../../vault/model/request/tokenize";
 import UpdateRequest from "../../vault/model/request/update";
 import { SkyflowConfig, StringKeyValueMapType } from "../../vault/types";
 import * as fs from 'fs';
+import * as path from 'path';
 import { isExpired } from "../jwt-utils";
 import logs from "../logs";
 import FileUploadOptions from "../../vault/model/options/fileUpload";
@@ -1000,12 +1001,17 @@ export const validateDeidentifyFileRequest = (deidentifyFileRequest: DeidentifyF
         throw new SkyflowError(SKYFLOW_ERROR_CODE.INVALID_FILE_TYPE);
     }
 
-    // Additional validation for File (browser)
+    // Additional validation for File
     if (file instanceof File) {
-        if (!file.name || !file.size) {
+        if (!file.name || typeof file.name !== 'string' || file.name.trim().length === 0) {
             throw new SkyflowError(SKYFLOW_ERROR_CODE.INVALID_FILE_TYPE);
         }
-    }
+        // Validate fileBaseName
+        const fileBaseName = path.parse(file.name).name;
+        if (!fileBaseName || typeof fileBaseName !== 'string' || fileBaseName.trim().length === 0) {
+            throw new SkyflowError(SKYFLOW_ERROR_CODE.INVALID_FILE_TYPE);
+        }
+  }
 
     // Validate options if provided
     if (deidentifyFileOptions) {

src/vault/skyflow/index.ts

@@ -53,7 +53,7 @@ class Skyflow {
         const vaultController = new VaultController(client);
         const detectController = new DetectController(client);
         printLog(parameterizedString(logs.infoLogs.VAULT_CONTROLLER_INITIALIZED, [config.vaultId]), MessageType.LOG, this.logLevel);
-        // printLog for detect controller
+        printLog(parameterizedString(logs.infoLogs.DETECT_CONTROLLER_INITIALIZED, [config.vaultId]), MessageType.LOG, this.logLevel);
         clients[config.vaultId] = { config, client, vaultController, detectController };
     }