aadarsh-st/SK-2521:Fixed copilot comments

Author: aadarsh-st

src/main/java/com/skyflow/utils/HttpUtility.java

@@ -76,14 +76,18 @@ public static String sendRequest(String method, URL url, JsonObject params, Map<
 
             int httpCode = connection.getResponseCode();
             String requestID = connection.getHeaderField("x-request-id");
-            HttpUtility.requestID = requestID.split(",")[0];
+            if (requestID != null) {
+                HttpUtility.requestID = requestID.split(",")[0];
+            } else {
+                HttpUtility.requestID = "Internal-SDK-" + UUID.randomUUID();
+            }
             Map<String, List<String>> responseHeaders = connection.getHeaderFields();
             Reader streamReader;
             if (httpCode > 299) {
                 if (connection.getErrorStream() != null)
                     streamReader = new InputStreamReader(connection.getErrorStream());
                 else {
-                    String description = appendRequestId("replace with description", requestID);
+                    String description = appendRequestId("Server returned error", requestID);
                     throw new SkyflowException(description);
                 }
             } else {

src/main/java/com/skyflow/utils/Utils.java

@@ -113,7 +113,7 @@ public static String constructConnectionURL(ConnectionConfig config, InvokeConne
                 String key = entry.getKey();
                 String value = entry.getValue();
                 try {
-                    String encodedValue = URLEncoder.encode(value, StandardCharsets.UTF_8.toString());
+                    String encodedValue = URLEncoder.encode(value, StandardCharsets.UTF_8.name());
                     filledURL = new StringBuilder(filledURL.toString().replace(String.format("{%s}", key), encodedValue));
                 } catch (Exception e) {
                     filledURL = new StringBuilder(filledURL.toString().replace(String.format("{%s}", key), value));
@@ -127,8 +127,8 @@ public static String constructConnectionURL(ConnectionConfig config, InvokeConne
                 String key = entry.getKey();
                 String value = entry.getValue();
                 try {
-                    String encodedKey = URLEncoder.encode(key, StandardCharsets.UTF_8.toString());
-                    String encodedValue = URLEncoder.encode(value, StandardCharsets.UTF_8.toString());
+                    String encodedKey = URLEncoder.encode(key, StandardCharsets.UTF_8.name());
+                    String encodedValue = URLEncoder.encode(value, StandardCharsets.UTF_8.name());
                     filledURL.append(encodedKey).append("=").append(encodedValue).append("&");
                 } catch (Exception e) {
                     filledURL.append(key).append("=").append(value).append("&");

src/main/java/com/skyflow/vault/controller/ConnectionController.java

@@ -92,7 +92,9 @@ public InvokeConnectionResponse invoke(InvokeConnectionRequest invokeConnectionR
             Object data = response;
             try {
                 data = JsonParser.parseString(response).getAsJsonObject();
-            } catch (Exception ignored) {}
+            } catch (Exception e) {
+                LogUtil.printErrorLog(ErrorLogs.INVOKE_CONNECTION_REQUEST_REJECTED.getLog());
+            }
             HashMap<String, String> metadata = new HashMap<>();
             metadata.put("requestId", HttpUtility.getRequestID());
             connectionResponse = new InvokeConnectionResponse(data, metadata, null);