Merge pull request #202 from skyflowapi/bharti/SK-2258-implement-insert-public-interface-for-v-3-flow-db-in-java-sdk

SK-2258 fix error response records

Author: skyflow-bharti

v3/src/main/java/com/skyflow/VaultClient.java

@@ -118,7 +118,7 @@ protected void updateExecutorInHTTP() {
                 .addInterceptor(chain -> {
                     Request original = chain.request();
                     Request requestWithAuth = original.newBuilder()
-                            .header("Authorization", "Bearer " + this.vaultConfig.getCredentials().getToken())
+                            .header("Authorization", "Bearer " + this.token)
                             .build();
                     return chain.proceed(requestWithAuth);
                 })

v3/src/main/java/com/skyflow/vault/controller/VaultController.java

@@ -78,12 +78,12 @@ public CompletableFuture<com.skyflow.vault.data.InsertResponse> bulkInsertAsync(
             configureInsertConcurrencyAndBatchSize(insertRequest.getValues().size());
             com.skyflow.generated.rest.resources.recordservice.requests.InsertRequest request = super.getBulkInsertRequestBody(insertRequest, super.getVaultConfig());
 
-            List<ErrorRecord> errorRecords = new ArrayList<>();
-            List<CompletableFuture<com.skyflow.vault.data.InsertResponse>> futures = this.insertBatchFutures(request, errorRecords);
+            List<CompletableFuture<com.skyflow.vault.data.InsertResponse>> futures = this.insertBatchFutures(request);
 
             return CompletableFuture.allOf(futures.toArray(new CompletableFuture[0]))
                     .thenApply(v -> {
                         List<Success> successRecords = new ArrayList<>();
+                        List<ErrorRecord> errorRecords = new ArrayList<>();
 
                         for (CompletableFuture<com.skyflow.vault.data.InsertResponse> future : futures) {
                             com.skyflow.vault.data.InsertResponse futureResponse = future.join();
@@ -114,7 +114,7 @@ private com.skyflow.vault.data.InsertResponse processSync(
         List<ErrorRecord> errorRecords = new ArrayList<>();
         List<Success> successRecords = new ArrayList<>();
 
-        List<CompletableFuture<com.skyflow.vault.data.InsertResponse>> futures = this.insertBatchFutures(insertRequest, errorRecords);
+        List<CompletableFuture<com.skyflow.vault.data.InsertResponse>> futures = this.insertBatchFutures(insertRequest);
 
         CompletableFuture<Void> allFutures = CompletableFuture.allOf(futures.toArray(new CompletableFuture[0]));
         allFutures.join();
@@ -137,7 +137,7 @@ private com.skyflow.vault.data.InsertResponse processSync(
 
 
     private List<CompletableFuture<com.skyflow.vault.data.InsertResponse>> insertBatchFutures(
-            com.skyflow.generated.rest.resources.recordservice.requests.InsertRequest insertRequest, List<ErrorRecord> errorRecords
+            com.skyflow.generated.rest.resources.recordservice.requests.InsertRequest insertRequest
     ) {
         List<InsertRecordData> records = insertRequest.getRecords().get();
 
@@ -151,12 +151,8 @@ private List<CompletableFuture<com.skyflow.vault.data.InsertResponse>> insertBat
                 int batchNumber = batchIndex;
                 CompletableFuture<com.skyflow.vault.data.InsertResponse> future = CompletableFuture
                         .supplyAsync(() -> insertBatch(batch, insertRequest.getTableName().get()), executor)
-                        .exceptionally(ex -> {
-                            LogUtil.printInfoLog(ErrorLogs.PROCESSING_ERROR_RESPONSE.getLog());
-                            errorRecords.addAll(handleBatchException(ex, batch, batchNumber, batches));
-                            return null;
-                        })
-                        .thenApply(response -> formatResponse(response, batchNumber, insertBatchSize));
+                        .thenApply(response -> formatResponse(response, batchNumber, insertBatchSize))
+                        .exceptionally(ex -> new com.skyflow.vault.data.InsertResponse(null, handleBatchException(ex, batch, batchNumber, batches)));
                 futures.add(future);
             }
         } finally {