Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multiple DbProviders #408

Closed
bravecobra opened this issue Nov 16, 2019 · 3 comments
Closed

Adding support for multiple DbProviders #408

bravecobra opened this issue Nov 16, 2019 · 3 comments
Assignees

Comments

@bravecobra
Copy link
Contributor

I noticed lots of issues being reports regarded missing database migrations.

In EF Core it is possible add migrations for multiple DbProviders: https://docs.microsoft.com/en-us/ef/core/managing-schemas/migrations/providers?tabs=dotnet-core-cli

So instead/on top of having the end-user having to generate the migrations for him/herself, we can provide those migrations already and allow for choosing the correct DbProvider through configuration. This would also allow for upgrading existing docker containers.
We should also allow the end-user to provide his/her own set of migrations, should they choose to do so. There might a couple of rogue migrations in existence with custom changes. All that through configuration of course.

@skoruba
Copy link
Owner

skoruba commented Nov 16, 2019

I am glad that you suggest this idea, because I am working on this locally currently. I will add the ef migrations into source control for multiple db providers, because it will help for a lot of use cases.
It will be possible to switch among db providers from appsettings.json.

@skoruba skoruba self-assigned this Nov 16, 2019
@skoruba skoruba added the task Task label Nov 16, 2019
@revitteth
Copy link

As a newbie to this repo I've been working through getting this to run in docker and have stumbled with the migrations as my machine is bare and I'm relying on docker for .net etc. This would be an awesome change to speed up getting it up and running out of the box :).

@skoruba
Copy link
Owner

skoruba commented Jan 24, 2020

I am closing this issue, it was released in master branch.

@skoruba skoruba closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants