Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all add_* methods on Card have a description keyword #309

Closed
BenjaminBossan opened this issue Mar 2, 2023 · 3 comments
Closed

Ensure that all add_* methods on Card have a description keyword #309

BenjaminBossan opened this issue Mar 2, 2023 · 3 comments
Labels
good first issue Good for newcomers model cards

Comments

@BenjaminBossan
Copy link
Collaborator

After the refactoring of model cards, some add_* methods got a description keyword to preserve feature parity with the previous implementation. Not all methods got this keyword, but it would be good to add it to all those methods. The reason is that it allows to get a result that is otherwise not easy to achieve and it is more consistent.

See also discussion here.
@adrinjalali adrinjalali added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 3, 2023
@EdAbati
Copy link
Contributor

EdAbati commented Mar 3, 2023

I can have a look at this, if it's ok :)

@BenjaminBossan
Copy link
Collaborator Author

Oh, sorry, I added this with some other changes in #310, forgot to link this issue..

@adrinjalali adrinjalali removed the help wanted Extra attention is needed label Mar 6, 2023
@BenjaminBossan BenjaminBossan mentioned this issue Mar 7, 2023
Closed
@adrinjalali
Copy link
Member

Resolved in #310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers model cards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrinjalali @BenjaminBossan @EdAbati