You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was discussed here, I'll copy the points over (with slight modification):
We have a tricky situation in our Card class where there can be multiple sources of truth for what the actual model is. One source is the model attribute, the other the model as (optionally) defined by metadata.model_file.
self.model is a model instance and there is nometadata.model_file
self.model is a model instance and there is a metadata.model_file
self.model is a str or Path and there is nometadata.model_file
self.model is a str or Path and there is a metadata.model_file and they're identical
self.model is a str or Path and there is a metadata.model_file and they're different
I think the getting started code snippet should always refer to the model_file from metadata if present. For case 3, one could argue that the path from self.model should be used for the getting started code snippet, but it's a bit surprising.
For the model diagram and hyperparams, I would argue we should use the data from self.model.
Ideally, we could agree on a "single source of truth" for the model, but it's not clear to me how to do that, as we don't have any mechanism to enforce that they're referring to the same model.
The text was updated successfully, but these errors were encountered:
This was discussed here, I'll copy the points over (with slight modification):
We have a tricky situation in our
Card
class where there can be multiple sources of truth for what the actual model is. One source is themodel
attribute, the other the model as (optionally) defined bymetadata.model_file
.self.model
is a model instance and there is nometadata.model_file
self.model
is a model instance and there is ametadata.model_file
self.model
is astr
orPath
and there is nometadata.model_file
self.model
is astr
orPath
and there is ametadata.model_file
and they're identicalself.model
is astr
orPath
and there is ametadata.model_file
and they're differentI think the getting started code snippet should always refer to the model_file from metadata if present. For case 3, one could argue that the path from
self.model
should be used for the getting started code snippet, but it's a bit surprising.For the model diagram and hyperparams, I would argue we should use the data from self.model.
Ideally, we could agree on a "single source of truth" for the model, but it's not clear to me how to do that, as we don't have any mechanism to enforce that they're referring to the same model.
The text was updated successfully, but these errors were encountered: