Skip to content

merge #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 124 commits into from
Dec 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
53ef71b
Add bundle linting and tests to the release script (#11662)
watadarkstar Nov 26, 2017
0c164bb
Upload build on the same node where it happens (#11666)
gaearon Nov 26, 2017
d445cd6
Bump Node devEngines to 8.x
gaearon Nov 27, 2017
0182769
Show nicer message on syntax errors
gaearon Nov 27, 2017
a65a8ab
Use async/await in Rollup scripts (#11669)
gaearon Nov 27, 2017
f6894dc
Set fragment export flags to true (#11672)
clemmy Nov 27, 2017
fe551de
Enable bundle tests for React.Fragment (#11673)
gaearon Nov 27, 2017
878feeb
Remove accidentally duplicated tests (#11675)
gaearon Nov 27, 2017
158f040
Lint untracked files with `yarn linc` (#11665)
accordeiro Nov 27, 2017
b542f42
Update README URLS to HTTPS (#11635)
him2him2 Nov 28, 2017
7788bcd
Do not fail `yarn linc` for ignored file warning (#11615) (#11641)
HeroProtagonist Nov 28, 2017
a2b6b6b
Migrate to CircleCI2.0 and Add AppVeyor for master-only branch (#11605)
raphamorim Nov 28, 2017
b89dc25
Record sizes
gaearon Nov 28, 2017
db04541
CI: remove unnecessary Yarn download (#11684)
thymikee Nov 28, 2017
8e876d2
Move ReactFiberTreeReflection to react-reconciler/reflection (#11683)
adamsau Nov 28, 2017
c611d2c
Amend changelog
gaearon Nov 28, 2017
363f4f1
[WIP] Fix for fiber root scheduling memory leak (#11644)
trueadm Nov 28, 2017
5a42586
Updating package versions for release 16.2.0
Nov 28, 2017
edb2b3d
Update bundle sizes for 16.2.0 release
Nov 28, 2017
53ab194
Blacklist spyOn(). Add explicit spyOnProd() and spyOnDevAndProd() (#1…
bvaughn Nov 28, 2017
5f9b493
Fix CI fact uploading (#11693)
gaearon Nov 28, 2017
e5cacb2
Stop ESLint from looking for a configuration file in parent folders (…
skiritsis Nov 28, 2017
18bbd64
Add 16.2.0 to changelog
gaearon Nov 28, 2017
9895a0f
Added ReactFeatureFlags shim for React Native (#11694)
bvaughn Nov 28, 2017
1b55ad2
root.createBatch (#11473)
acdlite Nov 29, 2017
2ae4c62
Always set pendingProps to the next props (#11580)
acdlite Nov 29, 2017
b097a34
refactor: scripts/error-codes (#11697)
Nov 29, 2017
c1b2a34
Rewrite ReactTreeTraversal-test.js using public APIs (#11664)
timjacobi Nov 29, 2017
bc1b7f3
Try to fix AppVeyor (#11702)
gaearon Nov 29, 2017
bc21578
Add more tasks to AppVeyor
gaearon Nov 29, 2017
9e07008
Disable Flow on AppVeyor
gaearon Nov 29, 2017
6340d6c
Delete Fiber test tracker (#11704)
gaearon Nov 29, 2017
9491dee
Throw if `document` is missing by the time invokeGuardedCallbackDev r…
gaearon Nov 29, 2017
8c1c5d7
Fixes path in package.json build script (#11707)
fitiskin Nov 29, 2017
3e64b18
Deprecate injecting custom event plugins (#11690)
gaearon Nov 29, 2017
e0c3113
Remove empty value for boolean attributes in SSR (#11708)
aweary Nov 29, 2017
c3f1b6c
Prevent infinite loop when SSR-rendering a portal (#11709)
gaearon Nov 29, 2017
d83916e
Rewrite SelectEventPlugin-test to test behavior using Public API (#11…
skiritsis Nov 29, 2017
c78db58
Record sizes
gaearon Nov 30, 2017
2decfe9
events: convert var to let/const (#11714)
raphamorim Nov 30, 2017
3c977de
react: convert var to let/const (#11715)
raphamorim Nov 30, 2017
8cbc16f
Unify the way we fork modules (#11711)
gaearon Nov 30, 2017
e997756
react-art: convert var to let/const (#11720)
raphamorim Nov 30, 2017
060581b
Fix issues with the new fork plugin (#11723)
gaearon Nov 30, 2017
642a678
Replace ReactFiberErrorLogger injection with static forks (#11717)
gaearon Nov 30, 2017
7d6b243
Ensure ReactFiberErrorDialogWWW.showErrorDialog exists
gaearon Nov 30, 2017
f57d963
Rewrote ReactIncrementalPerf-test using only public API.(#11299) (#11…
abiduzz420 Nov 30, 2017
46b3c3e
Use static injection for ReactErrorUtils (#11725)
gaearon Nov 30, 2017
3f736c3
Test: create TapEventPlugin-test (#11727)
madeinfree Nov 30, 2017
fd69c23
Use defaultValue instead of setAttribute('value') (#11534)
nhunzaker Nov 30, 2017
ea97148
react-native-renderer: convert vars to let/const (#11722)
raphamorim Nov 30, 2017
b3e27b2
react-rt-renderer, react-cs-renderer, react-call-return: Convert vars…
raphamorim Nov 30, 2017
8ec2ed4
Move HTML and SVG configs into DOMProperty (#11728)
gaearon Nov 30, 2017
6074664
react-reconciler: convert vars into let/const (#11729)
raphamorim Nov 30, 2017
2a1b1f3
react-test-renderer: convert vars into let/const (#11731)
raphamorim Dec 1, 2017
6c1fba5
shared: convert vars into let/const (#11730)
raphamorim Dec 1, 2017
f99ecce
Record sizes
gaearon Dec 1, 2017
0a2ed64
Remove dead code from DOMPropertyOperations (#11740)
nhunzaker Dec 1, 2017
59763bf
Add explicit warning assertions to ReactDOMInput-test (#11744)
gaearon Dec 1, 2017
ffe8546
Update the attribute table
gaearon Dec 1, 2017
8540768
Fix benchmark runner (#11749)
gaearon Dec 2, 2017
31ea0aa
Add a test for bad Map polyfill, and work around Rollup bug (#11745)
gaearon Dec 2, 2017
8ce5367
Use the same value synchronization function on number blur (#11746)
nhunzaker Dec 2, 2017
62f8a82
Pin lighthouse at 2.0.0
gaearon Dec 4, 2017
2091c62
Add test fixture for initial input validation bug in Firefox (#11760)
nhunzaker Dec 4, 2017
323efbc
Ensure value and defaultValue do not assign functions and symbols (#1…
nhunzaker Dec 4, 2017
d7f6ece
Remove the unused shim
gaearon Dec 4, 2017
4d0e8fc
ReactDOM.createRoot creates an async root (#11769)
acdlite Dec 4, 2017
37e4329
Remove vars (#11766)
raphamorim Dec 5, 2017
6d24290
Issue #11257(Updated) - Change build process to include npm pack and …
yu-tian113 Dec 5, 2017
2e29637
Record sizes
gaearon Dec 5, 2017
1637b43
Changed the way we double-invoke cWM lifecycle hook (#11764)
bvaughn Dec 5, 2017
48616e5
react-dom: convert packages/react-dom/src/__tests__ (#11776)
raphamorim Dec 5, 2017
3145639
https fb.me links (#11779)
sophiebits Dec 5, 2017
5bd2321
Remove vars (#11780)
raphamorim Dec 6, 2017
19bc2dd
Fix autoFocus for hydration content when it is mismatched (#11737)
koba04 Dec 6, 2017
f72043a
Refactor the build scripts (#11787)
gaearon Dec 6, 2017
ff3c1b8
Add `yarn debug-test` (#11791)
gaearon Dec 7, 2017
9fa0875
Mention how to use debuggers
gaearon Dec 7, 2017
2d7aafd
Oops
gaearon Dec 7, 2017
8256823
ValidateDOMNesting tests(#11299) (#11742)
anushreesubramani Dec 7, 2017
41f920e
Add a test-only transform to catch infinite loops (#11790)
gaearon Dec 7, 2017
5301c41
Revert "Remove empty value for boolean attributes in SSR (#11708)" (#…
aweary Dec 7, 2017
f93e34e
Remove an extra allocation for open source bundles (#11797)
gaearon Dec 7, 2017
52eb59d
Remove IE8-specific focus polyfill (#11800)
gaearon Dec 7, 2017
9cccde9
Add `yarn build --pretty` (#11801)
gaearon Dec 7, 2017
bee4baf
Oops, fix CI
gaearon Dec 8, 2017
6e258c1
Move isAttributeNameSafe to DOMProperty (#11802)
aweary Dec 8, 2017
ac630e4
Adds deprecation warning for ReactDOM.unstable_createPortal (#11747)
ManasJayanth Dec 8, 2017
cda9fb0
Add more coverage for custom elements (#11811)
gaearon Dec 8, 2017
47783e8
Refactor DOM attribute code (#11804)
gaearon Dec 8, 2017
d9869a4
Revert "Refactor DOM attribute code (#11804)" (#11814)
gaearon Dec 8, 2017
f23dd71
Remove unused wheel event detection in isEventSupported (#11822)
nhunzaker Dec 9, 2017
51e3f49
Deduplication of warn when selected is set on <option> (#11821)
watadarkstar Dec 10, 2017
abe0faf
Fix wrong deduplication condition
gaearon Dec 10, 2017
4c3470e
Refactor DOM attribute code (take two) (#11815)
gaearon Dec 10, 2017
abdbb16
Record sizes
gaearon Dec 10, 2017
a5025b1
fix #11759. false positive warning in IE11 when using React.Fragment …
XaveScor Dec 11, 2017
e8e62eb
use different eslint config for es6 and es5 (#11794)
ctxhou Dec 11, 2017
7299238
Update Rollup deps (#11829)
gaearon Dec 11, 2017
963b5d6
Update changelog
gaearon Dec 12, 2017
73265fc
Simplify SyntheticEvent declarations (#11837)
gaearon Dec 12, 2017
b77b123
Call and Return components should use ReactElement (#11834)
acdlite Dec 12, 2017
7a72aa0
Record sizes
acdlite Dec 13, 2017
8ec146c
Rudimentary tests for not covered entry points (#11835)
yu-tian113 Dec 13, 2017
cc52e06
Prevent BeforeInputPlugin from returning [null, null] (#11848)
nhunzaker Dec 14, 2017
d906de7
Use `declare module.exports` syntax for flow libdefs (#11861)
samwgoldman Dec 15, 2017
7242a5c
Use binary numbers representation directly (#11873)
alexeyraspopov Dec 18, 2017
ef9f1b6
Update flow (0.61.0) and declare context type (#11840)
raphamorim Dec 18, 2017
e40f6a9
Upload build stats to the server (#11880)
gaearon Dec 18, 2017
247c524
Update results.json from master before the build (#11882)
gaearon Dec 18, 2017
faa4218
Fixed an issue #11853 - window.opera=null problem (#11854)
alisherdavronov Dec 19, 2017
9ff3ce6
Add noModule boolean attribute (#11900)
aweary Dec 22, 2017
cf96d84
[Dev] Adds module and bundle type metadata to the rollup results json…
orta Dec 23, 2017
0280e93
Fix typos (#11868)
tbroadley Dec 23, 2017
25321dc
Temporarily remove a script section that crashes
gaearon Dec 23, 2017
021a567
We can add this back now (should fix CI)
gaearon Dec 23, 2017
bf9b0ad
This will fix CI, this time for real
gaearon Dec 24, 2017
5bf6087
Fix a few more issues that should fix the CI
gaearon Dec 24, 2017
32797fd
We can reenable this now
gaearon Dec 24, 2017
251193d
Fix writing stats to the file
gaearon Dec 24, 2017
e5cd4dd
Record sizes
gaearon Dec 24, 2017
d88a033
Temporarily disable downloading the results file
gaearon Dec 24, 2017
dd8b387
Reënable stats downloading
gaearon Dec 24, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
42 changes: 42 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
version: 2
jobs:
build:

docker:
- image: circleci/node:8

environment:
TZ: /usr/share/zoneinfo/America/Los_Angeles
TRAVIS_REPO_SLUG: facebook/react

parallelism: 4

steps:
- checkout

- run: echo $CIRCLE_COMPARE_URL | cut -d/ -f7

- restore_cache:
name: Restore node_modules cache
keys:
- v1-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}
- v1-node-{{ arch }}-{{ .Branch }}-
- v1-node-{{ arch }}-

- run:
name: Nodejs Version
command: node --version

- run:
name: Install Packages
command: yarn install

- run:
name: Test Packages
command: ./scripts/circleci/test_entry_point.sh

- save_cache:
name: Save node_modules cache
key: v1-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}
paths:
- node_modules
5 changes: 5 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const ERROR = 2;
module.exports = {
extends: 'fbjs',

// Stop ESLint from looking for a configuration file in parent folders
'root': true,

plugins: [
'react',
'react-internal',
Expand Down Expand Up @@ -60,5 +63,7 @@ module.exports = {

globals: {
spyOnDev: true,
spyOnDevAndProd: true,
spyOnProd: true,
},
};
5 changes: 1 addition & 4 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
<PROJECT_ROOT>/scripts/rollup/shims/facebook-www/.*
<PROJECT_ROOT>/scripts/rollup/shims/react-native/.*

# Note: intentionally *don't* ignore /scripts/rollup/shims/rollup/
# because it is part of the build and isn't external.

<PROJECT_ROOT>/.*/node_modules/y18n/.*
<PROJECT_ROOT>/node_modules/chrome-devtools-frontend/.*
<PROJECT_ROOT>/node_modules/devtools-timeline-model/.*
Expand Down Expand Up @@ -42,4 +39,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError

[version]
^0.57.3
^0.61.0
9 changes: 5 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
6. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
7. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
8. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
9. If you haven't already, complete the CLA.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
10. If you haven't already, complete the CLA.

**Learn more about contributing:** https://reactjs.org/docs/how-to-contribute.html
43 changes: 42 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,49 @@
Click to see more.
</summary>

### React

* Fix a false positive warning in IE11 when using `React.Fragment`. ([@XaveScor](https://github.com/XaveScor) in [#11823](https://github.com/facebook/react/pull/11823))

### React DOM

* Fix minor DOM input bugs in IE and Safari. ([@nhunzaker](https://github.com/nhunzaker) in [#11534](https://github.com/facebook/react/pull/11534))
* Fix containing elements getting focused on SSR markup mismatch. ([@koba04](https://github.com/koba04) in [#11737](https://github.com/facebook/react/pull/11737))
* Fix `value` and `defaultValue` to ignore Symbol values. ([@nhunzaker](https://github.com/nhunzaker) in [#11741](https://github.com/facebook/react/pull/11741))
* Throw with a meaningful message if the component runs after jsdom has been destroyed. ([@gaearon](https://github.com/gaearon) in [#11677](https://github.com/facebook/react/pull/11677))
* Deduplicate warning messages about `<option selected>`. ([@watadarkstar](https://github.com/watadarkstar) in [#11821](https://github.com/facebook/react/pull/11821))
* Deprecate `ReactDOM.unstable_createPortal()` in favor of `ReactDOM.createPortal()`. ([@prometheansacrifice](https://github.com/prometheansacrifice) in [#11747](https://github.com/facebook/react/pull/11747))

### React DOM Server

* Prevent an infinite loop when attempting to render portals with SSR. ([@gaearon](https://github.com/gaearon) in [#11709](https://github.com/facebook/react/pull/11709))

</details>

## 16.2.0 (November 28, 2017)

### React

* Add `Fragment` as named export to React. ([@clemmy](https://github.com/clemmy) in [#10783](https://github.com/facebook/react/pull/10783))
* Support experimental Call/Return types in `React.Children` utilities. ([@MatteoVH](https://github.com/MatteoVH) in [#11422](https://github.com/facebook/react/pull/11422))

### React DOM

* Fix radio buttons not getting checked when using multiple lists of radios. ([@landvibe](https://github.com/landvibe) in [#11227](https://github.com/facebook/react/pull/11227))
* Fix radio buttons not receiving the `onChange` event in some cases. ([@jquense](https://github.com/jquense) in [#11028](https://github.com/facebook/react/pull/11028))

### React Test Renderer

* Fix `setState()` callback firing too early when called from `componentWillMount`. ([@accordeiro](https://github.com/accordeiro) in [#11507](https://github.com/facebook/react/pull/11507))

### React Reconciler

* Expose `react-reconciler/reflection` with utilities useful to custom renderers. ([@rivenhk](https://github.com/rivenhk) in [#11683](https://github.com/facebook/react/pull/11683))

### Internal Changes

* Many tests were rewritten against the public API. Big thanks to [everyone who contributed](https://github.com/facebook/react/issues/11299)!

## 16.1.1 (November 13, 2017)

### React
Expand Down Expand Up @@ -574,7 +615,7 @@ Each of these changes will continue to work as before with a new warning until t
- React DOM now correctly handles `borderImageOutset`, `borderImageWidth`, `borderImageSlice`, `floodOpacity`, `strokeDasharray`, and `strokeMiterlimit` as unitless CSS properties. ([@rofrischmann](https://github.com/rofrischmann) in [#6210](https://github.com/facebook/react/pull/6210) and [#6270](https://github.com/facebook/react/pull/6270))
- React DOM now supports the `onAnimationStart`, `onAnimationEnd`, `onAnimationIteration`, `onTransitionEnd`, and `onInvalid` events. Support for `onLoad` has been added to `object` elements. ([@tomduncalf](https://github.com/tomduncalf) in [#5187](https://github.com/facebook/react/pull/5187), [@milesj](https://github.com/milesj) in [#6005](https://github.com/facebook/react/pull/6005), and [@ara4n](https://github.com/ara4n) in [#5781](https://github.com/facebook/react/pull/5781))
- React DOM now defaults to using DOM attributes instead of properties, which fixes a few edge case bugs. Additionally the nullification of values (ex: `href={null}`) now results in the forceful removal, no longer trying to set to the default value used by browsers in the absence of a value. ([@syranide](https://github.com/syranide) in [#1510](https://github.com/facebook/react/pull/1510))
- React DOM does not mistakingly coerce `children` to strings for Web Components. ([@jimfb](https://github.com/jimfb) in [#5093](https://github.com/facebook/react/pull/5093))
- React DOM does not mistakenly coerce `children` to strings for Web Components. ([@jimfb](https://github.com/jimfb) in [#5093](https://github.com/facebook/react/pull/5093))
- React DOM now correctly normalizes SVG `<use>` events. ([@edmellum](https://github.com/edmellum) in [#5720](https://github.com/facebook/react/pull/5720))
- React DOM does not throw if a `<select>` is unmounted while its `onChange` handler is executing. ([@sambev](https://github.com/sambev) in [#6028](https://github.com/facebook/react/pull/6028))
- React DOM does not throw in Windows 8 apps. ([@Andrew8xx8](https://github.com/Andrew8xx8) in [#6063](https://github.com/facebook/react/pull/6063))
Expand Down
39 changes: 39 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
image: Visual Studio 2017

# Fix line endings in Windows. (runs before repo cloning)
init:
- git config --global core.autocrlf input

environment:
matrix:
- nodejs_version: 8

# Finish on first failed build
matrix:
fast_finish: true

platform:
- x64

branches:
only:
- master

# Disable Visual Studio build and deploy
build: off
deploy: off

install:
- ps: Install-Product node $env:nodejs_version $env:platform
- yarn install

test_script:
- node --version
- yarn lint
- yarn flow
- yarn build
- yarn test

cache:
- node_modules
- "%LOCALAPPDATA%/Yarn"
40 changes: 0 additions & 40 deletions circle.yml

This file was deleted.

Loading