doctor: verify Android SDK version #177
Conversation
| } | ||
| } else { | ||
| let sdkAdbPath = "\(androidHome)/platform-tools/adb" | ||
| try await checkVersion(title: "Android SDK version", cmd: [sdkAdbPath, "--version"], min: Version("36.0.0"), pattern: "Version ([0-9.]+)", hint: " (install from https://developer.android.com/studio)") |
There was a problem hiding this comment.
This is checking the SDK version, not the adb version (which we already check above, for the adb in the PATH). There are two versions in the output, one for the actual adb version and the other for the SDK version:
Android Debug Bridge version 1.0.41
Version 36.0.2-14143358
Installed as /Users/marc/Library/Android/sdk/platform-tools/adb
Running on Darwin 24.6.0 (arm64)
I understand that the purpose of this extra check is to validate the presence of the ANDROID_HOME (either environment, or our guess about where it is), but we don't have a minimum SDK requirement of 36.0.0. It might be better to just re-check the same ADB version as above.
There was a problem hiding this comment.
Yes, I was checking the SDK version on purpose. (If someone tries to use a preposterously ancient Android SDK or an untested new version, I think skip doctor should show that.)
So, I think we should pick a plausible minimum supported SDK version. 29.0.0?
dfabulich
force-pushed
the
doctor-android-home
branch
from
e10ca78 to
370ada5
Compare
|
I cranked the minimum down to 29.0.0 (which seems pretty plausible to me) |
2 participants
Fixes skiptools/skip#605
Skip Pull Request Checklist:
swift test