Skip to content

Commit a50b41e

Browse files
mhorowitzTj
authored andcommitted
Expose setGlobalVariable in CatalystInstance interface
Summary: this helps with cleaning up some tests public Reviewed By: astreet Differential Revision: D2816285 fb-gh-sync-id: 37c4da7bdb3c8b5439184316bb5a8939160b40a3
1 parent b291b6c commit a50b41e

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstance.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import java.util.Collection;
1313

1414
import com.facebook.react.bridge.queue.CatalystQueueConfiguration;
15+
import com.facebook.react.common.annotations.VisibleForTesting;
1516
import com.facebook.proguard.annotations.DoNotStrip;
1617
import com.facebook.react.common.annotations.VisibleForTesting;
1718

@@ -66,4 +67,7 @@ public interface CatalystInstance {
6667
boolean supportsProfiling();
6768
void startProfiler(String title);
6869
void stopProfiler(String title, String filename);
70+
71+
@VisibleForTesting
72+
void setGlobalVariable(String propName, String jsonValue);
6973
}

ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -306,11 +306,6 @@ public CatalystQueueConfiguration getCatalystQueueConfiguration() {
306306
return mCatalystQueueConfiguration;
307307
}
308308

309-
@VisibleForTesting
310-
public ReactBridge getBridge() {
311-
return mBridge;
312-
}
313-
314309
@Override
315310
public <T extends JavaScriptModule> T getJSModule(Class<T> jsInterface) {
316311
return Assertions.assertNotNull(mJSModuleRegistry).getJavaScriptModule(jsInterface);
@@ -366,6 +361,12 @@ public void stopProfiler(String title, String filename) {
366361
mBridge.stopProfiler(title, filename);
367362
}
368363

364+
@VisibleForTesting
365+
@Override
366+
public void setGlobalVariable(String propName, String jsonValue) {
367+
mBridge.setGlobalVariable(propName, jsonValue);
368+
}
369+
369370
private String buildModulesConfigJSONProperty(
370371
NativeModuleRegistry nativeModuleRegistry,
371372
JavaScriptModulesConfig jsModulesConfig) {

0 commit comments

Comments
 (0)