Version 2.11.0-167.0.dev

Merge commit 'f0d1fe173c2474bea3d0f6b1c22405fa0f884021' into 'dev'

Author: Dart CI

DEPS

@@ -101,7 +101,7 @@ vars = {
   "ffi_rev": "454ab0f9ea6bd06942a983238d8a6818b1357edb",
   "fixnum_rev": "16d3890c6dc82ca629659da1934e412292508bba",
   "glob_rev": "e9f4e6b7ae8abe5071461cf8f47191bb19cf7ef6",
-  "html_rev": "083a36cd801a4b787ba156b7c6e4c8b2e2daed4a",
+  "html_rev": "22f17e97fedeacaa1e945cf84d8016284eed33a6",
   "http_io_rev": "2fa188caf7937e313026557713f7feffedd4978b",
   "http_multi_server_rev" : "ea269f79321d659208402088f3297e8920a88ee6",
   "http_parser_rev": "6e63a97b5aaa2b4d1215fe01683e51fb73258e54",

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -27,6 +27,7 @@ import 'package:analysis_server/src/services/correction/dart/convert_to_relative
 import 'package:analysis_server/src/services/correction/dart/convert_to_set_literal.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_where_type.dart';
 import 'package:analysis_server/src/services/correction/dart/create_method.dart';
+import 'package:analysis_server/src/services/correction/dart/inline_invocation.dart';
 import 'package:analysis_server/src/services/correction/dart/make_final.dart';
 import 'package:analysis_server/src/services/correction/dart/remove_argument.dart';
 import 'package:analysis_server/src/services/correction/dart/remove_await.dart';
@@ -175,6 +176,10 @@ class BulkFixProcessor {
     LintNames.prefer_if_null_operators: [
       ConvertToIfNull.newInstance,
     ],
+    LintNames.prefer_inlined_adds: [
+      ConvertAddAllToSpread.newInstance,
+      InlineInvocation.newInstance,
+    ],
     LintNames.prefer_int_literals: [
       ConvertToIntLiteral.newInstance,
     ],

pkg/analysis_server/test/src/services/correction/fix/bulk/inline_invocation_test.dart

@@ -0,0 +1,33 @@
+// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analysis_server/src/services/linter/lint_names.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import 'bulk_fix_processor.dart';
+
+void main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(InlineInvocationTest);
+  });
+}
+
+@reflectiveTest
+class InlineInvocationTest extends BulkFixProcessorTest {
+  @override
+  String get lintCode => LintNames.prefer_inlined_adds;
+
+  Future<void> test_singleFile() async {
+    await resolveTestUnit('''
+var l = []..add('a')..add('b');
+var l2 = ['a', 'b']..add('c');
+var l3 = ['a']..addAll(['b', 'c']);
+''');
+    await assertHasFix('''
+var l = ['a']..add('b');
+var l2 = ['a', 'b', 'c'];
+var l3 = ['a', 'b', 'c'];
+''');
+  }
+}

pkg/analysis_server/test/src/services/correction/fix/bulk/test_all.dart

@@ -29,6 +29,7 @@ import 'convert_to_single_quoted_strings_test.dart'
 import 'convert_to_spread_test.dart' as convert_to_spread;
 import 'convert_to_where_type_test.dart' as convert_to_where_type;
 import 'create_method_test.dart' as create_method;
+import 'inline_invocation_test.dart' as inline_invocation;
 import 'make_final_test.dart' as make_final;
 import 'remove_argument_test.dart' as remove_argument;
 import 'remove_await_test.dart' as remove_await;
@@ -83,6 +84,7 @@ void main() {
     convert_to_spread.main();
     convert_to_where_type.main();
     create_method.main();
+    inline_invocation.main();
     make_final.main();
     remove_argument.main();
     remove_await.main();

pkg/analysis_server/tool/bulk_fix/supported_lints.dart

@@ -0,0 +1,14 @@
+// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analysis_server/src/services/correction/bulk_fix_processor.dart';
+
+/// Print lints that are bulk-fixable in a format that can be included in
+/// analysis options.
+void main() {
+  print('    # bulk-fixable lints');
+  for (var lintName in BulkFixProcessor.lintProducerMap.keys) {
+    print('    - $lintName');
+  }
+}

sdk/lib/html/dart2js/html_dart2js.dart

@@ -40160,7 +40160,7 @@ Function _registerCustomElement(context, document, String tag, [Map? options]) {
   //    ...
   //    var e = document.createElement('x-foo');
 
-  var extendsTagName = '';
+  String? extendsTagName = '';
   Type? type;
   if (options != null) {
     extendsTagName = options['extends'];

tools/VERSION

@@ -27,5 +27,5 @@ CHANNEL dev
 MAJOR 2
 MINOR 11
 PATCH 0
-PRERELEASE 166
+PRERELEASE 167
 PRERELEASE_PATCH 0

tools/dom/src/dart2js_CustomElementSupport.dart

@@ -81,7 +81,7 @@ Function _registerCustomElement(context, document, String tag, [Map? options]) {
   //    ...
   //    var e = document.createElement('x-foo');
 
-  var extendsTagName = '';
+  String? extendsTagName = '';
   Type? type;
   if (options != null) {
     extendsTagName = options['extends'];

tools/dom/templates/html/impl/impl_Element.darttemplate

@@ -1390,7 +1390,7 @@ $endif
       contextElement = _parseDocument$NULLASSERT.createElement(tagName);
       _parseDocument$NULLASSERT.body$NULLASSERT.append(contextElement);
     }
-    var fragment;
+    DocumentFragment fragment;
     if (Range.supportsCreateContextualFragment &&
         _canBeUsedToCreateContextualFragment) {
       _parseRange$NULLASSERT.selectNodeContents(contextElement);

tools/dom/templates/html/impl/impl_IDBFactory.darttemplate

@@ -24,7 +24,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS
           'version and onUpgradeNeeded must be specified together'));
     }
     try {
-      var request;
+      OpenDBRequest request;
       if (version != null) {
         request = _open(name, version);
       } else {