Skip to content

Commit cdb0e8f

Browse files
Mike KleinSkia Commit-Bot
authored andcommitted
demote -fsanitize=pointer-overflow to warning
Clang 10 added a new check we and libjpeg-turbo fail. We need to investigate these failures, but I don't want that to stop us rolling clang_win. Bug: skia:9731 Change-Id: Ifdbb16ea0e2bacd30547d4a82a839563a9496d9f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260948 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
1 parent 35c64f6 commit cdb0e8f

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

gn/BUILD.gn

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,13 @@ config("default") {
277277
"-fno-sanitize-recover=$sanitizers",
278278
"-fsanitize-blacklist=$_blacklist",
279279
]
280+
281+
# TODO(mtklein): we need to fix "nullptr + k" issues
282+
# where k != 0 in C++, or in C, k == anything at all.
283+
# We have failures in Skia and libjpeg-turbo, at least.
284+
# See skia:9731.
285+
cflags += [ "-fsanitize-recover=pointer-overflow" ]
286+
280287
ldflags += [ "-fsanitize=$sanitizers" ]
281288

282289
if (is_win) {

0 commit comments

Comments
 (0)