[vm, service] Fix and enable more services tests.

Change-Id: I3e96b3fdcb30def43c7b87183a925bd1668fb6a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133087
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Author: rmacnak-google

runtime/observatory/lib/src/service/object.dart

@@ -1905,6 +1905,16 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
     });
   }
 
+  Future<ServiceObject> invoke(ServiceObject target, String selector,
+      [List<ServiceObject> arguments = const <ServiceObject>[]]) {
+    Map params = {
+      'targetId': target.id,
+      'selector': selector,
+      'argumentIds': arguments.map((arg) => arg.id).toList(),
+    };
+    return invokeRpc('invoke', params);
+  }
+
   Future<ServiceObject> eval(ServiceObject target, String expression,
       {Map<String, ServiceObject> scope, bool disableBreakpoints: false}) {
     Map params = {

runtime/observatory/tests/service/developer_extension_test.dart

@@ -11,53 +11,43 @@ import 'package:unittest/unittest.dart';
 import 'service_test_common.dart';
 import 'test_helper.dart';
 
-Future<ServiceExtensionResponse> Handler(String method,
-                                         Map paremeters) {
+Future<ServiceExtensionResponse> Handler(String method, Map paremeters) {
   print('Invoked extension: $method');
   switch (method) {
     case 'ext..delay':
-      Completer c = new Completer();
+      Completer c = new Completer<ServiceExtensionResponse>();
       new Timer(new Duration(seconds: 1), () {
         c.complete(new ServiceExtensionResponse.result(jsonEncode({
-            'type': '_delayedType',
-            'method': method,
-            'parameters': paremeters,
-          })));
+          'type': '_delayedType',
+          'method': method,
+          'parameters': paremeters,
+        })));
       });
       return c.future;
     case 'ext..error':
-      return new Future.value(
-              new ServiceExtensionResponse.error(
-                  ServiceExtensionResponse.extensionErrorMin,
-                  'My error detail.'));
+      return new Future<ServiceExtensionResponse>.value(
+          new ServiceExtensionResponse.error(
+              ServiceExtensionResponse.extensionErrorMin, 'My error detail.'));
     case 'ext..exception':
       throw "I always throw!";
     case 'ext..success':
-      return new Future.value(
+      return new Future<ServiceExtensionResponse>.value(
           new ServiceExtensionResponse.result(jsonEncode({
-              'type': '_extensionType',
-              'method': method,
-              'parameters': paremeters,
-          })));
+        'type': '_extensionType',
+        'method': method,
+        'parameters': paremeters,
+      })));
     case 'ext..null':
       return null;
     case 'ext..nullFuture':
-      return new Future.value(null);
+      return new Future<ServiceExtensionResponse>.value(null);
   }
 }
 
-Future<ServiceExtensionResponse> LanguageErrorHandler(String method,
-                                                      Map paremeters) {
-  // The following is an intentional syntax error.
-  klajsdlkjfad
-}
-
 void test() {
   registerExtension('ext..delay', Handler);
   debugger();
-  postEvent('ALPHA', {
-    'cat': 'dog'
-  });
+  postEvent('ALPHA', {'cat': 'dog'});
   debugger();
   registerExtension('ext..error', Handler);
   registerExtension('ext..exception', Handler);
@@ -71,15 +61,20 @@ void test() {
     exceptionThrown = true;
   }
   expect(exceptionThrown, isTrue);
-  registerExtension('ext..languageError', LanguageErrorHandler);
 }
 
 var tests = <IsolateTest>[
   hasStoppedAtBreakpoint,
   (Isolate isolate) async {
     await isolate.load();
-    expect(isolate.extensionRPCs.length, 1);
-    expect(isolate.extensionRPCs[0], equals('ext..delay'));
+    // Note: extensions other than those is this test might already be
+    // registered by core libraries.
+    expect(isolate.extensionRPCs, contains('ext..delay'));
+    expect(isolate.extensionRPCs, isNot(contains('ext..error')));
+    expect(isolate.extensionRPCs, isNot(contains('ext..exception')));
+    expect(isolate.extensionRPCs, isNot(contains('ext..null')));
+    expect(isolate.extensionRPCs, isNot(contains('ext..nullFuture')));
+    expect(isolate.extensionRPCs, isNot(contains('ext..success')));
   },
   resumeIsolateAndAwaitEvent(Isolate.kExtensionStream, (ServiceEvent event) {
     expect(event.kind, equals(ServiceEvent.kExtension));
@@ -127,27 +122,19 @@ var tests = <IsolateTest>[
       await isolate.invokeRpcNoUpgrade('ext..nullFuture', {});
     } on ServerRpcException catch (e, st) {
       expect(e.code, equals(ServiceExtensionResponse.extensionError));
-      expect(e.message, equals('Extension handler must complete to a '
-                               'ServiceExtensionResponse'));
+      expect(
+          e.message,
+          equals('Extension handler must complete to a '
+              'ServiceExtensionResponse'));
     }
 
-    result = await isolate.invokeRpcNoUpgrade('ext..success',
-                                              {'apple': 'banana'});
+    result =
+        await isolate.invokeRpcNoUpgrade('ext..success', {'apple': 'banana'});
     expect(result['type'], equals('_extensionType'));
     expect(result['method'], equals('ext..success'));
     expect(result['parameters']['isolateId'], isNotNull);
     expect(result['parameters']['apple'], equals('banana'));
-
-
-    try {
-      result = await isolate.invokeRpcNoUpgrade('ext..languageError', {});
-    } on ServerRpcException catch (e, st) {
-      expect(e.code, equals(ServiceExtensionResponse.extensionError));
-      expect(e.message, stringContainsInOrder([
-          'developer_extension_test.dart',
-          'semicolon expected']));
-    }
   },
 ];
 
-main(args) async => runIsolateTests(args, tests, testeeConcurrent:test);
+main(args) async => runIsolateTests(args, tests, testeeConcurrent: test);

runtime/observatory/tests/service/developer_service_get_isolate_id_test.dart

@@ -31,6 +31,12 @@ Future testeeMain() async {
   dev.debugger();
 }
 
+@pragma("vm:entry-point")
+getSelfId() => selfId;
+
+@pragma("vm:entry-point")
+getChildId() => childId;
+
 // tester state:
 Service.Isolate initialIsolate;
 Service.Isolate localChildIsolate;
@@ -65,7 +71,7 @@ var tests = <VMTest>[
 
     // Grab self id.
     Service.Instance localSelfId =
-        await initialIsolate.eval(rootLbirary, 'selfId');
+        await initialIsolate.invoke(rootLbirary, 'getSelfId');
 
     // Check that the id reported from dart:developer matches the id reported
     // from the service protocol.
@@ -74,7 +80,7 @@ var tests = <VMTest>[
 
     // Grab the child isolate's id.
     Service.Instance localChildId =
-        await initialIsolate.eval(rootLbirary, 'childId');
+        await initialIsolate.invoke(rootLbirary, 'getChildId');
 
     // Check that the id reported from dart:developer matches the id reported
     // from the service protocol.

runtime/observatory/tests/service/kill_running_test.dart

@@ -14,8 +14,6 @@ testMain() async {
 }
 
 var tests = <IsolateTest>[
-  // Stopped at 'debugger' statement.
-  isolateIsRunning,
   // Kill the app
   (Isolate isolate) async {
     Map<String, dynamic> params = <String, dynamic>{};

runtime/observatory/tests/service/service_kernel.status

@@ -3,31 +3,31 @@
 # BSD-style license that can be found in the LICENSE file.
 
 [ $compiler == app_jitk ]
+add_breakpoint_rpc_kernel_test: SkipByDesign # No incremental compiler available.
 async_generator_breakpoint_test: SkipByDesign # No incremental compiler available.
 bad_reload_test: RuntimeError
 break_on_activation_test: SkipByDesign # No incremental compiler available.
 complex_reload_test: RuntimeError
 debugger_inspect_test: SkipByDesign # No incremental compiler available.
 debugger_location_second_test: RuntimeError
-developer_service_get_isolate_id_test: SkipByDesign # No incremental compiler available.
 eval_internal_class_test: SkipByDesign # No incremental compiler available.
 eval_regression_flutter20255_test: SkipByDesign # No incremental compiler available.
 eval_test: SkipByDesign # No incremental compiler available.
 evaluate_activation_in_method_class_test: RuntimeError # Issue 35505
 evaluate_activation_test: SkipByDesign # No incremental compiler available.
 evaluate_async_closure_test: SkipByDesign # No incremental compiler available.
 evaluate_class_type_parameters_test: SkipByDesign # No incremental compiler available.
+evaluate_function_type_parameters_test: SkipByDesign # No incremental compiler available.
 evaluate_in_async_activation_test: SkipByDesign # No incremental compiler available.
 evaluate_in_async_star_activation_test: SkipByDesign # No incremental compiler available.
 evaluate_in_frame_rpc_test: SkipByDesign # No incremental compiler available.
 evaluate_in_frame_with_scope_test: SkipByDesign # No incremental compiler available.
 evaluate_in_sync_star_activation_test: SkipByDesign # No incremental compiler available.
+evaluate_with_escaping_closure_test: SkipByDesign # No incremental compiler available.
 evaluate_with_scope_test: SkipByDesign # No incremental compiler available.
 pause_on_exceptions_test: SkipByDesign # No incremental compiler available.
-regress_34841_test: RuntimeError # http://dartbug.com/34841
 rewind_optimized_out_test: SkipByDesign # No incremental compiler available.
 rewind_test: SkipByDesign # No incremental compiler available.
-simple_reload_test: RuntimeError, Timeout # Issue 35506
 
 [ $compiler == dartkp ]
 add_breakpoint_rpc_kernel_test: RuntimeError
@@ -76,7 +76,7 @@ debugger_location_test: Skip, Timeout
 debugging_inlined_finally_test: Skip, Timeout
 debugging_test: RuntimeError
 dev_fs_spawn_test: RuntimeError
-developer_extension_test: CompileTimeError
+developer_extension_test: Skip, Timeout
 developer_service_get_isolate_id_test: Skip, Timeout
 eval_internal_class_test: RuntimeError
 eval_regression_flutter20255_test: Skip, Timeout
@@ -108,7 +108,6 @@ issue_27238_test: Skip, Timeout
 issue_27287_test: Skip, Timeout
 issue_30555_test: RuntimeError
 kill_paused_test: Skip, Timeout
-kill_running_test: RuntimeError
 library_dependency_test: CompileTimeError
 local_variable_declaration_test: Skip, Timeout
 logging_test: Skip, Timeout
@@ -179,7 +178,6 @@ weak_properties_test: CompileTimeError
 yield_positions_with_finally_test: RuntimeError
 
 [ $fasta ]
-developer_extension_test: CompileTimeError
 get_isolate_after_language_error_test: CompileTimeError
 
 [ $arch == arm64 && $compiler == dartk ]
@@ -278,7 +276,6 @@ break_on_activation_test: RuntimeError # Issue #34736
 breakpoint_in_package_parts_class_file_uri_test: RuntimeError # Issue #34736
 complex_reload_test: Skip # Times out on sim architectures, also RuntimeError.
 debugger_inspect_test: RuntimeError, Timeout # Issue #34736
-developer_service_get_isolate_id_test: RuntimeError # Issue #34736
 eval_internal_class_test: RuntimeError # Issue #34736
 eval_regression_flutter20255_test: SkipByDesign # No incremental compiler available.
 eval_test: RuntimeError # Issue #34736

runtime/tests/vm/vm.status

@@ -11,7 +11,6 @@ cc/IsolateReload_PendingStaticCall_DefinedToNSM: Fail # Issue 32981
 cc/IsolateReload_PendingStaticCall_NSMToDefined: Fail, Crash # Issue 32981. Fails on non-Windows, crashes on Windows (because of test.py special handline)
 cc/IsolateReload_PendingUnqualifiedCall_InstanceToStatic: Fail # Issue 32981
 cc/IsolateReload_PendingUnqualifiedCall_StaticToInstance: Fail # Issue 32981
-cc/Profiler_StringInterpolation: Fail # Issue 37208
 dart/data_uri_import_test/none: SkipByDesign
 dart/emit_aot_size_info_flag_test: Pass, Slow # Spawns several subprocesses
 dart/slow_path_shared_stub_test: Pass, Slow # Uses --shared-slow-path-triggers-gc flag.