Skip to content

Commit ba6087f

Browse files
jwrencommit-bot@chromium.org
authored andcommitted
Override and allow the hidden option to be set on MigrateCommand
`hidden` is implemented in the same manner that we do for flutter daemon, see https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/daemon.dart#L49 Change-Id: I6dcb4a4f5e1a71ba7e90956cd15b4b95524dd2bb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138106 Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Jaime Wren <jwren@google.com>
1 parent f97018b commit ba6087f

File tree

3 files changed

+25
-2
lines changed

3 files changed

+25
-2
lines changed

pkg/dartdev/lib/dartdev.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class DartdevRunner<int> extends CommandRunner {
2727
addCommand(AnalyzeCommand(verbose: verbose));
2828
addCommand(CreateCommand(verbose: verbose));
2929
addCommand(FormatCommand(verbose: verbose));
30-
addCommand(MigrateCommand(logProvider: () => log));
30+
addCommand(MigrateCommand(logProvider: () => log, hidden: !verbose));
3131
addCommand(PubCommand(verbose: verbose));
3232
addCommand(TestCommand(verbose: verbose));
3333
}

pkg/dartdev/test/commands/flag_test.dart

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,26 @@ void help() {
2727
expect(result.stdout, contains('Usage: dart <command> [arguments]'));
2828
expect(result.stdout, contains('Global options:'));
2929
expect(result.stdout, contains('Available commands:'));
30+
expect(result.stdout, contains('analyze '));
31+
expect(result.stdout, contains('create '));
32+
expect(result.stdout, contains('format '));
33+
expect(result.stdout, isNot(contains('migrate ')));
34+
});
35+
36+
test('--help --verbose', () {
37+
p = project();
38+
var result = p.runSync('--help', ['--verbose']);
39+
40+
expect(result.exitCode, 0);
41+
expect(result.stdout, contains('migrate '));
42+
});
43+
44+
test('--help -v', () {
45+
p = project();
46+
var result = p.runSync('--help', ['-v']);
47+
48+
expect(result.exitCode, 0);
49+
expect(result.stdout, contains('migrate '));
3050
});
3151

3252
// For each command description, assert that the values are not empty, don't

pkg/dartfix/lib/src/migrate/migrate.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ typedef LogProvider = Logger Function();
2626
class MigrateCommand extends Command {
2727
final LogProvider logProvider;
2828

29+
@override
30+
final bool hidden;
31+
2932
@override
3033
String get name => 'migrate';
3134

@@ -38,7 +41,7 @@ class MigrateCommand extends Command {
3841
return '${super.invocation} [project or directory]';
3942
}
4043

41-
MigrateCommand({this.logProvider}) {
44+
MigrateCommand({this.logProvider, this.hidden = false}) {
4245
MigrateOptions.defineOptions(argParser);
4346
}
4447

0 commit comments

Comments
 (0)