Remove AnalysisOptionsImpl.strongModeHints

Change-Id: I61b8aefb4935160bec20e52fb9c9482079387c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analysis_server/lib/src/status/diagnostics.dart

@@ -500,7 +500,6 @@ class ContextsPage extends DiagnosticPageWithNav {
         writeOption('Generate errors in SDK files', options.generateSdkErrors));
     b.write(writeOption('Generate hints', options.hint));
     b.write(writeOption('Preserve comments', options.preserveComments));
-    b.write(writeOption('Strong mode hints', options.strongModeHints));
 
     return b.toString();
   }

pkg/analyzer/lib/src/generated/engine.dart

@@ -472,12 +472,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @override
   bool preserveComments = true;
 
-  /// A flag indicating whether strong-mode inference hints should be
-  /// used.  This flag is not exposed in the interface, and should be
-  /// replaced by something more general.
-  // TODO(leafp): replace this with something more general
-  bool strongModeHints = false;
-
   @override
   bool trackCacheDependencies = true;
 
@@ -541,7 +535,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
     preserveComments = options.preserveComments;
     useFastaParser = options.useFastaParser;
     if (options is AnalysisOptionsImpl) {
-      strongModeHints = options.strongModeHints;
       implicitCasts = options.implicitCasts;
       implicitDynamic = options.implicitDynamic;
       strictInference = options.strictInference;
@@ -718,7 +711,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
       buffer.addBool(implicitDynamic);
       buffer.addBool(strictInference);
       buffer.addBool(strictRawTypes);
-      buffer.addBool(strongModeHints);
       buffer.addBool(useFastaParser);
 
       // Append enabled experiments.
@@ -810,7 +802,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
     _lintRules = null;
     patchPaths = {};
     preserveComments = true;
-    strongModeHints = false;
     trackCacheDependencies = true;
     useFastaParser = true;
   }
@@ -819,9 +810,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @override
   void setCrossContextOptionsFrom(AnalysisOptions options) {
     enableLazyAssignmentOperators = options.enableLazyAssignmentOperators;
-    if (options is AnalysisOptionsImpl) {
-      strongModeHints = options.strongModeHints;
-    }
   }
 
   /// Return whether the given lists of lints are equal.

pkg/analyzer/lib/src/task/strong/checker.dart

@@ -1006,15 +1006,14 @@ class CodeChecker extends RecursiveAstVisitor {
         errorCode.name.startsWith('TOP_LEVEL_')) {
       severity = ErrorSeverity.ERROR;
     }
-    if (severity != ErrorSeverity.INFO || _options.strongModeHints) {
-      int begin = node is AnnotatedNode
-          ? node.firstTokenAfterCommentAndMetadata.offset
-          : node.offset;
-      int length = node.end - begin;
-      var source = (node.root as CompilationUnit).declaredElement.source;
-      var error = AnalysisError(source, begin, length, errorCode, arguments);
-      reporter.onError(error);
-    }
+
+    int begin = node is AnnotatedNode
+        ? node.firstTokenAfterCommentAndMetadata.offset
+        : node.offset;
+    int length = node.end - begin;
+    var source = (node.root as CompilationUnit).declaredElement.source;
+    var error = AnalysisError(source, begin, length, errorCode, arguments);
+    reporter.onError(error);
   }
 
   void _validateTopLevelInitializer(String name, Expression n) {

pkg/analyzer/test/src/context/builder_test.dart

@@ -878,7 +878,6 @@ environment:
     );
     expect(actual.preserveComments, expected.preserveComments);
     expect(actual.strongMode, expected.strongMode);
-    expect(actual.strongModeHints, expected.strongModeHints);
     expect(actual.implicitCasts, expected.implicitCasts);
     expect(actual.implicitDynamic, expected.implicitDynamic);
     expect(actual.strictInference, expected.strictInference);

pkg/analyzer/test/src/task/strong/strong_test_helper.dart

@@ -273,7 +273,6 @@ class AbstractStrongTest with ResourceProviderMixin {
     expect(mainFile.exists, true, reason: '`/main.dart` is missing');
 
     AnalysisOptionsImpl analysisOptions = AnalysisOptionsImpl();
-    analysisOptions.strongModeHints = true;
     analysisOptions.implicitCasts = implicitCasts;
     analysisOptions.implicitDynamic = implicitDynamic;
     analysisOptions.strictInference = strictInference;