Skip to content

Commit 5335faa

Browse files
jonahryandavisCommit Bot
authored andcommitted
Robust validate_step_info in generate_stats.py
If there is a warning during validate_step_info and the step_info is None, the script should not attempt to update that step in the Spreadsheet object. Bug: angleproject:4030 Change-Id: Ib94ba82219745ee4ab36c52e9b1d3a04a76a05d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1872569 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 parent f228038 commit 5335faa

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

scripts/generate_stats.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -353,10 +353,7 @@ def get_step_info(build_name, step_name):
353353
append_errors.append(key)
354354
LOGGER.warning("Too many characters in column '" + key +
355355
"'. Output capped.")
356-
357-
if validate_step_info(step_info, build_name, step_name):
358-
return step_info
359-
return None
356+
return step_info
360357

361358

362359
# Returns the info for each step run on a given bot_name.
@@ -365,7 +362,11 @@ def get_bot_info(bot_name):
365362
info['step_names'] = get_step_names(info['build_name'])
366363
for step_name in info['step_names']:
367364
LOGGER.info("Parsing step '" + step_name + "'...")
368-
info[step_name] = get_step_info(info['build_name'], step_name)
365+
step_info = get_step_info(info['build_name'], step_name)
366+
if validate_step_info(step_info, info['build_name'], step_name):
367+
info[step_name] = step_info
368+
else:
369+
info['step_names'].remove(step_name)
369370
return info
370371

371372

0 commit comments

Comments
 (0)