Suppress flaky failure with MacOS/NVIDIA/OPENGL

shrekshao · Commit Bot · commit 51e653f03f26 · 2020-01-07T02:11:12.000Z
Seeing intermittent failure on this test only on MacOS/NVIDIA/OPENGL. Suppress for now. Bug: angleproject:4258 Change-Id: Ibda30954019410e3b6d069986b2cd0ad26533c00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984850 Reviewed-by: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com>
diff --git a/src/tests/gl_tests/VertexAttributeTest.cpp b/src/tests/gl_tests/VertexAttributeTest.cpp
@@ -1203,6 +1203,9 @@ TEST_P(VertexAttributeOORTest, ANGLEDrawArraysOutOfBoundsCases)
 // Verify that using a different start vertex doesn't mess up the draw.
 TEST_P(VertexAttributeTest, DrawArraysWithBufferOffset)
 {
+    // anglebug.com/4258
+    ANGLE_SKIP_TEST_IF(IsOpenGL() && IsNVIDIA() && IsOSX());
+
     // anglebug.com/4163
     ANGLE_SKIP_TEST_IF(IsD3D11() && IsNVIDIA() && IsWindows7());
 

Original file line number	Diff line number	Diff line change
`@@ -1203,6 +1203,9 @@ TEST_P(VertexAttributeOORTest, ANGLEDrawArraysOutOfBoundsCases)`
`1203`	`1203`	`// Verify that using a different start vertex doesn't mess up the draw.`
`1204`	`1204`	`TEST_P(VertexAttributeTest, DrawArraysWithBufferOffset)`
`1205`	`1205`	`{`
	`1206`	`+ // anglebug.com/4258`
	`1207`	`+ ANGLE_SKIP_TEST_IF(IsOpenGL() && IsNVIDIA() && IsOSX());`
	`1208`	`+`
`1206`	`1209`	`// anglebug.com/4163`
`1207`	`1210`	`ANGLE_SKIP_TEST_IF(IsD3D11() && IsNVIDIA() && IsWindows7());`
`1208`	`1211`