Skip to content

Commit 3744b2a

Browse files
johnstiles-googleSkia Commit-Bot
authored andcommitted
Revert "Re-enable -Wdeprecated-copy-dtor."
This reverts commit a888940. Reason for revert: breaking Build-Win-Clang-x86_64-Release-ANGLE, Build-Win-Clang-x86_64-Release-Shared, etc. Original change's description: > Re-enable -Wdeprecated-copy-dtor. > > This was mostly working already, because violating this warning would > break one of our builds, Build-Debian10-EMCC-wasm-Release-WasmGMTests. > > Example: https://status.skia.org/logs/BmABdx9EQKaH89CcbwU2/605bf360-b5b1-4a72-9e9f-465444f7f36c > > This did require a fix to Dawn (thanks to cwallez@): > https://dawn-review.googlesource.com/c/dawn/+/30701 > > Change-Id: I17723bda02f13895f9e19ea2e94dc48c2cdb1572 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/330741 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=mtklein@google.com,brianosman@google.com,johnstiles@google.com Change-Id: Id31265d4c39f8774f0668aaa54d8f6fc10de1ee7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/332178 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
1 parent a5eff5d commit 3744b2a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gn/BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,8 +498,8 @@ config("warnings") {
498498
"-Wdeprecated-attributes",
499499
"-Wdeprecated-comma-subscript",
500500
"-Wdeprecated-copy",
501-
"-Wdeprecated-copy-dtor",
502501

502+
#"-Wdeprecated-copy-dtor",
503503
#"-Wdeprecated-declarations",
504504
"-Wdeprecated-dynamic-exception-spec",
505505
"-Wdeprecated-enum-compare",

0 commit comments

Comments
 (0)