Version 2.12.0-142.0.dev

Merge commit '690ae7a7ba4f8038dcf58721411beb673c860438' into 'dev'

Author: Dart CI

BUILD.gn

@@ -159,16 +159,64 @@ if (is_fuchsia) {
   import("third_party/fuchsia/sdk/linux/build/component.gni")
   import("third_party/fuchsia/sdk/linux/build/package.gni")
 
-  fuchsia_component("fuchsia_test_component") {
-    testonly = true
-    data_deps = [ "runtime/bin:dart" ]
-    manifest = "build/fuchsia/dart.cmx"
+  template("dart_fuchsia_test_package") {
+    fuchsia_package(target_name) {
+      package_name = invoker.package_name
+      if (is_debug) {
+        package_name += "_debug"
+      } else if (is_release) {
+        package_name += "_release"
+      } else if (is_product) {
+        package_name += "_product"
+      }
+      testonly = true
+      deps = invoker.deps
+    }
+  }
 
-    resource_files = [
-      ".dart_tool/package_config.json",
-      "pkg/testing/test/hello_test.dart",
-      "tools/addlatexhash.dart",
-    ]
+  template("dart_fuchsia_test_component") {
+    fuchsia_component(target_name) {
+      testonly = true
+      data_deps = [ "runtime/bin:dart" ]
+      if (defined(invoker.data_deps)) {
+        data_deps += invoker.data_deps
+      }
+      manifest = "build/fuchsia/dart.cmx"
+
+      library_files = []
+      if (defined(invoker.library_files)) {
+        library_files += invoker.library_files
+      }
+      resource_files = [
+        ".dart_tool/package_config.json",
+        "pkg/testing/test/hello_test.dart",
+        "tools/addlatexhash.dart",
+      ]
+      resource_dirs = invoker.resource_dirs
+
+      resources = []
+      foreach(file, library_files) {
+        resources += [
+          {
+            path = root_out_dir + "/" + file
+            dest = "lib/" + file
+          },
+        ]
+      }
+      foreach(file, resource_files) {
+        resources += [
+          {
+            path = file
+            dest = "data/" + file
+          },
+        ]
+      }
+      resources +=
+          exec_script("tools/fuchsia/find_resources.py", resource_dirs, "json")
+    }
+  }
+
+  dart_fuchsia_test_component("fuchsia_test_component") {
     resource_dirs = [
       "tests/standalone_2",
       "pkg/async_helper",
@@ -190,30 +238,32 @@ if (is_fuchsia) {
       "third_party/pkg/string_scanner",
       "third_party/pkg/typed_data",
     ]
-
-    resources = []
-    foreach(file, resource_files) {
-      resources += [
-        {
-          path = file
-          dest = "data/" + file
-        },
-      ]
-    }
-    resources +=
-        exec_script("tools/fuchsia/find_resources.py", resource_dirs, "json")
   }
 
-  fuchsia_package("fuchsia_test_package") {
-    package_name = "dart_test_"
-    if (is_debug) {
-      package_name += "debug"
-    } else if (is_release) {
-      package_name += "release"
-    } else if (is_product) {
-      package_name += "product"
-    }
-    testonly = true
+  dart_fuchsia_test_package("fuchsia_test_package") {
+    package_name = "dart_test"
     deps = [ ":fuchsia_test_component" ]
   }
+
+  dart_fuchsia_test_component("fuchsia_ffi_test_component") {
+    data_deps = [
+      "runtime/bin:ffi_test_dynamic_library",
+      "runtime/bin:ffi_test_functions",
+    ]
+    library_files = [
+      "libffi_test_dynamic_library.so",
+      "libffi_test_functions.so",
+    ]
+    resource_dirs = [
+      "pkg/expect",
+      "pkg/meta",
+      "tests/ffi",
+      "third_party/pkg/ffi",
+    ]
+  }
+
+  dart_fuchsia_test_package("fuchsia_ffi_test_package") {
+    package_name = "dart_ffi_test"
+    deps = [ ":fuchsia_ffi_test_component" ]
+  }
 }

DEPS

@@ -565,7 +565,7 @@ deps = {
     "packages": [
       {
       "package": "fuchsia/sdk/gn/linux-amd64",
-      "version": "git_revision:8d5242d4f6ff8b7634b492700e60b0fd09abefa3"
+      "version": "git_revision:e0a61431eb6e28d31d293cbb0c12f6b3a089bba4"
       }
     ],
     "condition": 'host_os == "linux" and host_cpu == "x64"',

build/toolchain/fuchsia/BUILD.gn

@@ -17,9 +17,10 @@ if (use_goma) {
 }
 
 toolchain("fuchsia") {
-  assert(target_cpu == "x64", "We currently only support 'x64' for fuchsia.")
+  assert(target_cpu == "x64" || target_cpu == "arm64",
+         "We currently only support 'x64' and 'arm64' for fuchsia.")
   toolchain_bin =
-      rebase_path("//buildtools/$host_os-$target_cpu/clang/bin", root_out_dir)
+      rebase_path("//buildtools/$host_os-x64/clang/bin", root_out_dir)
   fuchsia_sdk = rebase_path("//third_party/fuchsia/sdk/$host_os", root_out_dir)
 
   # We can't do string interpolation ($ in strings) on things with dots in
@@ -34,6 +35,10 @@ toolchain("fuchsia") {
   strip = "${toolchain_bin}/llvm-strip"
 
   target_triple_flags = "--target=x86_64-fuchsia"
+  if (target_cpu == "arm64") {
+    target_triple_flags = "--target=aarch64-fuchsia"
+  }
+
   sysroot_flags = "--sysroot ${fuchsia_sdk}/arch/${target_cpu}/sysroot"
   lto_flags = ""
 
@@ -129,6 +134,11 @@ toolchain("fuchsia") {
     exename = "{{target_output_name}}{{output_extension}}"
     outfile = "{{root_out_dir}}/$exename"
     rspfile = "$outfile.rsp"
+
+    # Note that the unstripped_outfile is in the exe.stripped folder.
+    # We should probably clean this up, but changing this and dart.cmx
+    # to point ./dart instead of ./exe.stripped/dart makes the build
+    # fail because ./dart does not end up in the manifest file.
     unstripped_outfile = "{{root_out_dir}}/exe.stripped/$exename"
     command = "$compiler_prefix $ld $target_triple_flags $sysroot_flags $lto_flags {{ldflags}} -o $unstripped_outfile -Wl,--build-id -Wl,--start-group @$rspfile {{solibs}} -Wl,--end-group {{libs}} && ${strip} -o $outfile $unstripped_outfile"
     description = "LINK $outfile"

pkg/analysis_server/lib/src/services/correction/dart/add_null_check.dart

@@ -41,6 +41,8 @@ class AddNullCheck extends CorrectionProducer {
       toType = parent.declaredElement.type;
     } else if (parent is ArgumentList) {
       toType = target.staticParameterElement.type;
+    } else if (parent is IndexExpression) {
+      toType = parent.realTarget.staticType;
     } else {
       return;
     }

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -814,6 +814,9 @@ class FixProcessor extends BaseProcessor {
       CreateClass.newInstance,
       CreateMixin.newInstance,
     ],
+    CompileTimeErrorCode.UNCHECKED_USE_OF_NULLABLE_VALUE: [
+      AddNullCheck.newInstance,
+    ],
     CompileTimeErrorCode.UNDEFINED_ANNOTATION: [
       ChangeTo.annotation,
       CreateClass.newInstance,

pkg/analysis_server/test/src/services/correction/fix/add_null_check_test.dart

@@ -97,6 +97,19 @@ class A {
 ''');
   }
 
+  Future<void> test_indexExpression() async {
+    await resolveTestCode('''
+void f (List<String>? args) {
+  print(args[0]);
+}
+''');
+    await assertHasFix('''
+void f (List<String>? args) {
+  print(args![0]);
+}
+''');
+  }
+
   Future<void> test_initializer() async {
     await resolveTestCode('''
 void f(int? x) {

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -3973,7 +3973,8 @@ class BodyBuilder extends ScopeListener<JumpTarget>
   /// name.
   void pushQualifiedReference(Token start, Token periodBeforeName) {
     assert(checkState(start, [
-      /*suffix*/ if (periodBeforeName != null) ValueKinds.Identifier,
+      /*suffix*/ if (periodBeforeName != null)
+        unionOfKinds([ValueKinds.Identifier, ValueKinds.ParserRecovery]),
       /*type arguments*/ ValueKinds.TypeArgumentsOrNull,
       /*type*/ unionOfKinds([
         ValueKinds.Generator,
@@ -3982,7 +3983,18 @@ class BodyBuilder extends ScopeListener<JumpTarget>
         ValueKinds.ParserRecovery
       ])
     ]));
-    Identifier suffix = popIfNotNull(periodBeforeName);
+    Object suffixObject = popIfNotNull(periodBeforeName);
+    Identifier suffix;
+    if (suffixObject is Identifier) {
+      suffix = suffixObject;
+    } else {
+      assert(
+          suffixObject == null || suffixObject is ParserRecovery,
+          "Unexpected qualified name suffix $suffixObject "
+          "(${suffixObject.runtimeType})");
+      // There was a `.` without a suffix.
+    }
+
     Identifier identifier;
     List<UnresolvedType> typeArguments = pop();
     Object type = pop();

pkg/front_end/testcases/general/issue44347.dart

@@ -0,0 +1,9 @@
+// Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+test() {
+  Set<int>.();
+}
+
+main() {}

pkg/front_end/testcases/general/issue44347.dart.outline.expect

@@ -0,0 +1,7 @@
+library;
+import self as self;
+
+static method test() → dynamic
+  ;
+static method main() → dynamic
+  ;

pkg/front_end/testcases/general/issue44347.dart.strong.expect

@@ -0,0 +1,17 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/general/issue44347.dart:6:12: Error: Expected an identifier, but got '('.
+// Try inserting an identifier before '('.
+//   Set<int>.();
+//            ^
+//
+import self as self;
+import "dart:collection" as col;
+import "dart:core" as core;
+
+static method test() → dynamic {
+  col::LinkedHashSet::•<core::int*>();
+}
+static method main() → dynamic {}