Revert "Initial definition of fill rect op"

This reverts commit d3c92d9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Initial definition of fill rect op
> 
> Bug: skia:
> Change-Id: Ie0c99eb5163501853d1adc885bd3841f90a71924
> Reviewed-on: https://skia-review.googlesource.com/c/163486
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,csmartdalton@google.com,michaelludwig@google.com

Change-Id: Ib32f91a39d91aeb87982a7b19719485e4a1bf8ae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/173233
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>

Author: lhkbob

gm/drawquadset.cpp

@@ -123,7 +123,6 @@ gm_sources = [
   "$_gm/drawlooper.cpp",
   "$_gm/drawimageset.cpp",
   "$_gm/drawminibitmaprect.cpp",
-  "$_gm/drawquadset.cpp",
   "$_gm/drawregion.cpp",
   "$_gm/drawregionmodes.cpp",
   "$_gm/dropshadowimagefilter.cpp",

gn/gm.gni

@@ -262,8 +262,6 @@ skia_gpu_sources = [
   "$_src/gpu/ops/GrDrawOp.h",
   "$_src/gpu/ops/GrDrawVerticesOp.cpp",
   "$_src/gpu/ops/GrDrawVerticesOp.h",
-  "$_src/gpu/ops/GrFillRectOp.cpp",
-  "$_src/gpu/ops/GrFillRectOp.h",
   "$_src/gpu/ops/GrMeshDrawOp.cpp",
   "$_src/gpu/ops/GrMeshDrawOp.h",
   "$_src/gpu/ops/GrNonAAFillRectOp.cpp",

gn/gpu.gni

@@ -155,7 +155,6 @@ class GrProcessor {
         kPorterDuffXferProcessor_ClassID,
         kPremulFragmentProcessor_ClassID,
         kQuadEdgeEffect_ClassID,
-        kQuadPerEdgeAAGeometryProcessor_ClassID,
         kReplaceInputFragmentProcessor_ClassID,
         kRRectsGaussianEdgeFP_ClassID,
         kSeriesFragmentProcessor_ClassID,

src/gpu/GrProcessor.h

@@ -19,21 +19,7 @@
 // Allow some tolerance from floating point matrix transformations, but SkScalarNearlyEqual doesn't
 // support comparing infinity, and coords_form_rect should return true for infinite edges
 #define NEARLY_EQUAL(f1, f2) (f1 == f2 || SkScalarNearlyEqual(f1, f2, 1e-5f))
-// Similarly, support infinite rectangles by looking at the sign of infinities
-static bool dot_nearly_zero(const SkVector& e1, const SkVector& e2) {
-    static constexpr auto dot = SkPoint::DotProduct;
-    static constexpr auto sign = SkScalarSignAsScalar;
-
-    SkScalar dotValue = dot(e1, e2);
-    if (SkScalarIsNaN(dotValue)) {
-        // Form vectors from the signs of infinities, and check their dot product
-        dotValue = dot({sign(e1.fX), sign(e1.fY)}, {sign(e2.fX), sign(e2.fY)});
-    }
-
-    // Unfortunately must have a pretty healthy tolerance here or transformed rects that are
-    // effectively rectilinear will have edge dot products of around .005
-    return SkScalarNearlyZero(dotValue, 1e-2f);
-}
+#define NEARLY_ZERO(f1) NEARLY_EQUAL(f1, 0.f)
 
 // This is not the most performance critical function; code using GrQuad should rely on the faster
 // quad type from matrix path, so this will only be called as part of SkASSERT.
@@ -45,13 +31,18 @@ static bool coords_form_rect(const float xs[4], const float ys[4]) {
 }
 
 static bool coords_rectilinear(const float xs[4], const float ys[4]) {
+    // Edge from 0 to 1 should have the same length as edge from 3 to 2
+    // and edge from 1 to 3 should have the same length as edge from 2 to 0
+    // noo that makes it a parallelogram, need dot product between edge 0 to 1 and edge 1 to 3 = 0
+    // and 0-2 and 2-3 is 0.
+    static constexpr auto dot = SkPoint::DotProduct;
     SkVector e0{xs[1] - xs[0], ys[1] - ys[0]}; // Connects to e1 and e2(repeat)
     SkVector e1{xs[3] - xs[1], ys[3] - ys[1]}; // connects to e0(repeat) and e3
     SkVector e2{xs[0] - xs[2], ys[0] - ys[2]}; // connects to e0 and e3(repeat)
     SkVector e3{xs[2] - xs[3], ys[2] - ys[3]}; // connects to e1(repeat) and e2
 
-    return dot_nearly_zero(e0, e1) && dot_nearly_zero(e1, e3) &&
-           dot_nearly_zero(e2, e0) && dot_nearly_zero(e3, e2);
+    return NEARLY_ZERO(dot(e0, e1)) && NEARLY_ZERO(dot(e1, e3)) &&
+           NEARLY_ZERO(dot(e2, e0)) && NEARLY_ZERO(dot(e3, e2));
 }
 
 GrQuadType GrQuad::quadType() const {

src/gpu/GrQuad.cpp

@@ -44,7 +44,6 @@
 #include "ops/GrDrawAtlasOp.h"
 #include "ops/GrDrawOp.h"
 #include "ops/GrDrawVerticesOp.h"
-#include "ops/GrFillRectOp.h"
 #include "ops/GrAAFillRRectOp.h"
 #include "ops/GrLatticeOp.h"
 #include "ops/GrOp.h"
@@ -639,14 +638,6 @@ void GrRenderTargetContext::drawRect(const GrClip& clip,
     this->drawShapeUsingPathRenderer(clip, std::move(paint), aa, viewMatrix, GrShape(rect, *style));
 }
 
-void GrRenderTargetContext::drawQuadSet(const GrClip& clip, GrPaint&& paint, GrAA aa,
-                                        const SkMatrix& viewMatrix, const QuadSetEntry quads[],
-                                        int cnt) {
-    GrAAType aaType = this->chooseAAType(aa, GrAllowMixedSamples::kNo);
-    this->addDrawOp(clip, GrFillRectOp::MakeSet(fContext, std::move(paint), aaType, viewMatrix,
-                                                quads, cnt));
-}
-
 int GrRenderTargetContextPriv::maxWindowRectangles() const {
     return fRenderTargetContext->fRenderTargetProxy->maxWindowRectangles(
             *fRenderTargetContext->caps());

src/gpu/GrRenderTargetContext.cpp

@@ -127,17 +127,6 @@ class SK_API GrRenderTargetContext : public GrSurfaceContext {
                                  const SkRect& rect,
                                  const SkMatrix& localMatrix);
 
-    /** Used with drawQuadSet */
-    struct QuadSetEntry {
-        SkRect fRect;
-        SkPMColor4f fColor; // Overrides any color on the GrPaint
-        SkMatrix fLocalMatrix;
-        GrQuadAAFlags fAAFlags;
-    };
-
-    void drawQuadSet(const GrClip& clip, GrPaint&& paint, GrAA aa, const SkMatrix& viewMatrix,
-                     const QuadSetEntry[], int cnt);
-
     /**
      * Creates an op that draws a subrectangle of a texture. The passed color is modulated by the
      * texture's color. 'srcRect' specifies the rectangle of the texture to draw. 'dstRect'