Merge pull request #709 from sketch-hq/refactor-original-size-method

Remove resizeToOriginalSize method

Author: bomberstudios

CHANGELOG.json

@@ -1,6 +1,5 @@
 {
   "unreleased": [
-    "[New] Add `resizeToOriginalSize` method on `Image`",
     "[New] Add `size` property on `ImageData`"
   ],
   "releases": {

Source/dom/layers/Image.js

@@ -26,14 +26,6 @@ export class Image extends StyledLayer {
 
     super(layer)
   }
-
-  resizeToOriginalSize() {
-    if (this.isImmutable()) {
-      return this
-    }
-    this._object.resizeToOriginalSize()
-    return this
-  }
 }
 
 Image.type = Types.Image

Source/dom/layers/__tests__/Image.test.js

@@ -1,5 +1,5 @@
 /* globals expect, test */
-import { canBeLogged, base64Image } from '../../../test-utils'
+import { canBeLogged } from '../../../test-utils'
 import { Image } from '../..'
 
 test('should create an empty image', (context, document) => {
@@ -12,22 +12,3 @@ test('should create an empty image', (context, document) => {
   expect(image.image).toBe(null)
   canBeLogged(image, Image)
 })
-
-test('should resize image to its original size', (context, document) => {
-  const page = document.selectedPage
-
-  const image = new Image({
-    image: {
-      base64: base64Image,
-    },
-    parent: page,
-  })
-
-  expect(image.frame.width).toBe(100)
-  expect(image.frame.height).toBe(100)
-
-  image.resizeToOriginalSize()
-
-  expect(image.frame.width).toBe(50)
-  expect(image.frame.height).toBe(50)
-})

docs/api/Image.md

@@ -58,19 +58,13 @@ var imageLayer = new Image({
 
 By default, an `Image` layer will be created with a size of 100 × 100 pixels, unless you provide a `frame` property on its constructor.
 
-## Original Size
-
-```js
-imageLayer.resizeToOriginalSize()
+```javascript
+const image = imageLayer.image
+imageLayer.frame.width = image.size.width
+imageLayer.frame.height = image.size.height
 ```
 
-Adjust the Image to its original size. This is equivalent to pressing the 'Original Size' button in Sketch's Inspector.
-
-### Returns
-
-The current Image (useful if you want to chain the calls).
-
-For performance reasons, Sketch initializes the `Image` object lazily. So if you want to set the dimensions of your Image layer to those of the original file, you'll first need to create the object, and then call the `resizeToOriginalSize` method.
+For performance reasons, Sketch initializes the `Image` object lazily. So if you want to set the dimensions of your Image layer to those of the original file, you'll first need to create the object, and then set its frame dimensions.
 
 ## `ImageData`