Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons hover effects not noticeable with certain themes and presets #2938

Open
knd775 opened this issue Nov 8, 2024 · 1 comment
Open
Labels
bug Something isn't working
Milestone

Comments

@knd775
Copy link
Contributor

knd775 commented Nov 8, 2024

Current Behavior

On darker themes, buttons with preset-tonal or preset-tonal-surface don't perceptibly change on hover. For darker values, they don't change at all.

Expected Behavior

Noticeable hover effects on buttons

Steps To Reproduce

  1. Use a darker theme
  2. Create a button with preset-tonal
  3. Hover the button

Link to Reproduction / Stackblitz

No response

More Information

No response

@knd775 knd775 added the bug Something isn't working label Nov 8, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Nov 8, 2024
@endigo9740
Copy link
Contributor

Note for myself: the hover state expected is the brightness change from the .btn class here:
https://github.com/skeletonlabs/skeleton/blob/next/packages/skeleton/src/plugin/components/buttons.css#L7

This doesn't seem to play well with certain combinations of theme values and presets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants