Skip to content

Commit 56f1f3a

Browse files
authored
Conditional rendering for trigger button (#3223)
1 parent 9eb7881 commit 56f1f3a

File tree

4 files changed

+20
-9
lines changed

4 files changed

+20
-9
lines changed

.changeset/stale-coats-build.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@skeletonlabs/skeleton-svelte': patch
3+
---
4+
5+
bugfix: only render button wrapping around `trigger` if the snippet was provided

packages/skeleton-svelte/src/lib/components/Modal/Modal.svelte

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,11 @@
7070

7171
<span class="{base} {classes}" data-testid="modal">
7272
<!-- Trigger -->
73-
<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
74-
{@render trigger?.()}
75-
</button>
73+
{#if trigger}
74+
<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
75+
{@render trigger?.()}
76+
</button>
77+
{/if}
7678

7779
{#if api.open}
7880
<!-- Backdrop -->

packages/skeleton-svelte/src/lib/components/Popover/Popover.svelte

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,11 @@
6363

6464
<span class="{base} {classes}" data-testid="popover">
6565
<!-- Snippet: Trigger -->
66-
<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
67-
{@render trigger?.()}
68-
</button>
66+
{#if trigger}
67+
<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
68+
{@render trigger?.()}
69+
</button>
70+
{/if}
6971
<!-- Portal -->
7072
<div use:portal={{ disabled: !api.portalled }} {...api.getPositionerProps()} class="{positionerBase} {positionerClasses}">
7173
<!-- Popover -->

packages/skeleton-svelte/src/lib/components/Tooltip/Tooltip.svelte

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,11 @@
6464

6565
<span class="{base} {classes}" data-testid="tooltip">
6666
<!-- Snippet: Trigger -->
67-
<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
68-
{@render trigger?.()}
69-
</button>
67+
{#if trigger}
68+
<button {...triggerProps} class="{triggerBase} {triggerBackground} {triggerClasses}" {disabled} type="button">
69+
{@render trigger?.()}
70+
</button>
71+
{/if}
7072
<!-- Tooltip Content -->
7173
{#if api.open}
7274
<div {...api.getPositionerProps()} transition:fade={{ duration: 100 }} class="{positionerBase} {positionerClasses}">

0 commit comments

Comments
 (0)