Use Buffer.alloc and Buffer.from instead of new Buffer

Author: sitegui

Connection.js

@@ -55,7 +55,7 @@ function Connection(socket, parentOrOptions, callback) {
 	this.protocol = undefined
 	this.socket = socket
 	this.readyState = this.CONNECTING
-	this.buffer = new Buffer(0)
+	this.buffer = Buffer.alloc(0)
 	this.frameBuffer = null // string for text frames and InStream for binary frames
 	this.outStream = null // current allocated OutStream object for sending binary frames
 	this.key = null // the Sec-WebSocket-Key header
@@ -268,7 +268,7 @@ Connection.prototype.doRead = function () {
  */
 Connection.prototype.startHandshake = function () {
 	var str, i, key, headers, header
-	key = new Buffer(16)
+	key = Buffer.alloc(16)
 	for (i = 0; i < 16; i++) {
 		key[i] = Math.floor(Math.random() * 256)
 	}

OutStream.js

@@ -16,7 +16,7 @@ function OutStream(connection, minSize) {
 	var that = this
 	this.connection = connection
 	this.minSize = minSize
-	this.buffer = new Buffer(0)
+	this.buffer = Buffer.alloc(0)
 	this.hasSent = false // Indicates if any frame has been sent yet
 	stream.Writable.call(this)
 	this.on('finish', function () {
@@ -48,7 +48,7 @@ OutStream.prototype._write = function (chunk, encoding, callback) {
 			frameBuffer = frame.createBinaryFrame(this.buffer, !this.connection.server, !this.hasSent, false)
 			this.connection.socket.write(frameBuffer, encoding, callback)
 		}
-		this.buffer = new Buffer(0)
+		this.buffer = Buffer.alloc(0)
 		this.hasSent = true
 		if (this.connection.readyState !== this.connection.OPEN) {
 			callback()

README.md

@@ -183,7 +183,7 @@ var server = ws.createServer(function (conn) {
 	console.log("New connection")
 	conn.on("binary", function (inStream) {
 		// Empty buffer for collecting binary data
-		var data = new Buffer(0)
+		var data = Buffer.alloc(0)
 		// Read chunks of binary data and add to the buffer
 		inStream.on("readable", function () {
 		    var newData = inStream.read()

frame.js

@@ -13,7 +13,7 @@
 exports.createTextFrame = function (data, masked) {
 	var payload, meta
 
-	payload = new Buffer(data)
+	payload = Buffer.from(data)
 	meta = generateMetaData(true, 1, masked === undefined ? false : masked, payload)
 
 	return Buffer.concat([meta, payload], meta.length + payload.length)
@@ -34,7 +34,7 @@ exports.createBinaryFrame = function (data, masked, first, fin) {
 	first = first === undefined ? true : first
 	masked = masked === undefined ? false : masked
 	if (masked) {
-		payload = new Buffer(data.length)
+		payload = Buffer.alloc(data.length)
 		data.copy(payload)
 	} else {
 		payload = data
@@ -56,10 +56,10 @@ exports.createCloseFrame = function (code, reason, masked) {
 	var payload, meta
 
 	if (code !== undefined && code !== 1005) {
-		payload = new Buffer(reason === undefined ? '--' : '--' + reason)
+		payload = Buffer.from(reason === undefined ? '--' : '--' + reason)
 		payload.writeUInt16BE(code, 0)
 	} else {
-		payload = new Buffer(0)
+		payload = Buffer.alloc(0)
 	}
 	meta = generateMetaData(true, 8, masked === undefined ? false : masked, payload)
 
@@ -76,7 +76,7 @@ exports.createCloseFrame = function (code, reason, masked) {
 exports.createPingFrame = function (data, masked) {
 	var payload, meta
 
-	payload = new Buffer(data)
+	payload = Buffer.from(data)
 	meta = generateMetaData(true, 9, masked === undefined ? false : masked, payload)
 
 	return Buffer.concat([meta, payload], meta.length + payload.length)
@@ -92,7 +92,7 @@ exports.createPingFrame = function (data, masked) {
 exports.createPongFrame = function (data, masked) {
 	var payload, meta
 
-	payload = new Buffer(data)
+	payload = Buffer.from(data)
 	meta = generateMetaData(true, 10, masked === undefined ? false : masked, payload)
 
 	return Buffer.concat([meta, payload], meta.length + payload.length)
@@ -114,7 +114,7 @@ function generateMetaData(fin, opcode, masked, payload) {
 	len = payload.length
 
 	// Creates the buffer for meta-data
-	meta = new Buffer(2 + (len < 126 ? 0 : (len < 65536 ? 2 : 8)) + (masked ? 4 : 0))
+	meta = Buffer.alloc(2 + (len < 126 ? 0 : (len < 65536 ? 2 : 8)) + (masked ? 4 : 0))
 
 	// Sets fin and opcode
 	meta[0] = (fin ? 128 : 0) + opcode
@@ -138,7 +138,7 @@ function generateMetaData(fin, opcode, masked, payload) {
 
 	// Set the mask-key
 	if (masked) {
-		mask = new Buffer(4)
+		mask = Buffer.alloc(4)
 		for (i = 0; i < 4; i++) {
 			meta[start + i] = mask[i] = Math.floor(Math.random() * 256)
 		}