feat(sidebar): tooltip for the active-session indicator dot#782
Open
navarrotech wants to merge 1 commit into
Open
feat(sidebar): tooltip for the active-session indicator dot#782navarrotech wants to merge 1 commit into
navarrotech wants to merge 1 commit into
Conversation
The pulsing green dot next to a session row signals that the session had activity in the last 10 minutes, but the meaning was undocumented. Hovering it now shows a translated tooltip, and an aria-label exposes the same text to screen readers. Uses the existing shared Tooltip component (portal-positioned, so it is not clipped by the sidebar overflow). Translation key added to all eight sidebar locale files (en, de, it, ja, ko, ru, tr, zh-CN).
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe PR wraps the active session indicator dot in the sidebar with a Tooltip component, adding i18n-backed tooltip text describing a recently active session (last 10 minutes) and an accessibility label. The change includes the component update and translations across eight supported language locales. ChangesActive Session Indicator Tooltip Enhancement
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Testing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pulsing green dot to the left of a sidebar session row signals that the session had activity in the last 10 minutes (
isActive: diffInMinutes < 10insrc/components/sidebar/utils/utils.ts), but its meaning was undocumented. Users hovering it learn nothing.This PR adds a translated tooltip and an
aria-labelso the same information reaches keyboard / screen-reader users.Implementation notes
Tooltipcomponent fromsrc/shared/view/ui/Tooltip.tsx. It is portal-positioned, so it is not clipped by the sidebar's scroll container.position="right"keeps the tooltip out of the row, since the dot sits flush against the left edge.role="status"andaria-label, so screen readers announce it even though the visual cue is the colour + animation.tooltips.activeSessionIndicatoradded to all eight locale files: en, de, it, ja, ko, ru, tr, zh-CN.Test plan
Summary by CodeRabbit
New Features
Localization