CS/QA: various small tweaks #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are language constructs, not functions, so the parentheses are unnecessary.
This fixes up the one instance where there was still a long array used in the code base.
The `Helper::findContainingOpeningBracket()` method can return either an integer or `null`, so this comparison should be a strict comparison.
... instead of post-increment as it is less prone to surprising results if code is moved around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS/QA: use single quotes for text strings without embedded variables
CS/QA: always have a comma after each item in multi-line arrays
CS/QA: use
selfto refer to current classCS/QA: no need for parentheses with require/include
These are language constructs, not functions, so the parentheses are unnecessary.
CS/QA: consistently use short arrays
This fixes up the one instance where there was still a long array used in the code base.
CS/QA: use strict comparisons
The
Helper::findContainingOpeningBracket()method can return either an integer ornull, so this comparison should be a strict comparison.CS/QA: use pre-increment
... instead of post-increment as it is less prone to surprising results if code is moved around.