Skip to content

Commit 9e49a9b

Browse files
travis: Fix argument quoting for ./configure
When $USE_HOST or $EXTRAFLAGS are empty, we pass (due to quoting) an empty string as a parameter to ./configure, which then believes we want to use a deprecated syntax for specifing a host or a target and yells at us: > configure: WARNING: you should use --build, --host, --target The fixes are: - $EXTRAFLAGS could contain multiple flags and should not be quoted at all. - We can get rid of $USE_HOST by specifying --host="$HOST" directly.
1 parent 214cb3c commit 9e49a9b

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

contrib/travis.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
set -e
44
set -x
55

6-
if [ -n "$HOST" ]
7-
then
8-
export USE_HOST="--host=$HOST"
9-
fi
106
if [ "$HOST" = "i686-linux-gnu" ]
117
then
128
export CC="$CC -m32"
@@ -20,7 +16,8 @@ fi
2016
--enable-experimental="$EXPERIMENTAL" --enable-endomorphism="$ENDOMORPHISM" \
2117
--with-field="$FIELD" --with-bignum="$BIGNUM" --with-asm="$ASM" --with-scalar="$SCALAR" \
2218
--enable-ecmult-static-precomputation="$STATICPRECOMPUTATION" --with-ecmult-gen-precision="$ECMULTGENPRECISION" \
23-
--enable-module-ecdh="$ECDH" --enable-module-recovery="$RECOVERY" "$EXTRAFLAGS" "$USE_HOST"
19+
--enable-module-ecdh="$ECDH" --enable-module-recovery="$RECOVERY" \
20+
--host="$HOST" $EXTRAFLAGS
2421

2522
if [ -n "$BUILD" ]
2623
then

0 commit comments

Comments
 (0)