Allow applying markers via case(..., marks=...) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smheidrich
changed the title
|
That would be super helpful! I was just about to suggest the same changes. But I think, maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My suggestion for how to implement #7 that I mentioned at the end of that issue. Adds a new
marksparameter toParametrization.case(), in analogy to pytest's ownpytest.param(..., marks=...).As I wrote in #7, this solution has the drawback of introducing a new reserved keyword argument for
case(), but I still find it so much more ergonomic than the alternatives that to me it would be worth it. Might need to wait until the next major release though because it should be considered a breaking change...Thoughts?