Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: singular-gpispace/git-fans
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: singular-gpispace/git-fans
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: adapt_to_gspc_2106
Choose a head ref
  • 19 commits
  • 12 files changed
  • 1 contributor

Commits on Jul 16, 2021

  1. prepend CMake include directives with "util-cmake/"

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    2fcef7b View commit details
    Browse the repository at this point in the history

  2. require CMake mimimum version 3.13

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    d752850 View commit details
    Browse the repository at this point in the history

  3. cmake_minimum_required() should be first line of CMakeLists.txt

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    30634f0 View commit details
    Browse the repository at this point in the history

  4. require GPI-Space version 21.06

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    3236c6e View commit details
    Browse the repository at this point in the history

  5. include util-cmake/add_unit_test in CMakeLists.txt

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    52f6c85 View commit details
    Browse the repository at this point in the history

  6. enable testing properly 

    - including CTest also invokes enable_testing()
  (unless BUILD_TESTING is off)
    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    8447c21 View commit details
    Browse the repository at this point in the history

  7. do not link to FLINT for Singular library 

    - there should be no explicit dependency on FLINT
    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    eda5488 View commit details
    Browse the repository at this point in the history

  8. typo in find_library for GMP

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    8d7026b View commit details
    Browse the repository at this point in the history

  9. change RESOLVE_INTERFACE_FUNCTION() and adapt some callers 

    - when the scoped_dlhandle falls out of scope, the requested library
  might be unloaded, resulting in an invalid function pointer
    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    d44b56f View commit details
    Browse the repository at this point in the history

  10. add missing backslash in generate_statistics command in README.md

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    281dae3 View commit details
    Browse the repository at this point in the history

  11. remove FLINT directory from install instructions in README.md

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    90b2314 View commit details
    Browse the repository at this point in the history

  12. find GPI-Space via GPISpace_ROOT environment variable

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    c0490a7 View commit details
    Browse the repository at this point in the history

  13. remove option -DALLOW_ANY_GPISPACE_VERSION=true in README.md 

    - only useful if the find_GPISpace wrapper is used
    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    bbffa0b View commit details
    Browse the repository at this point in the history

  14. build tests only if BUILD_TESTING is set

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    d344453 View commit details
    Browse the repository at this point in the history

  15. disable warning more specifically

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    9273e9b View commit details
    Browse the repository at this point in the history

  16. use googletest 1.8.1, disable its installation 

    - the version previously used does not support INSTALL_GTEST
    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    9a6fe32 View commit details
    Browse the repository at this point in the history

  17. warning needs no longer be disabled

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    c049207 View commit details
    Browse the repository at this point in the history

  18. disable bundling

    @lristau
    lristau committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    905cb47 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. delete unused header

    @lristau
    lristau committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    cfe1148 View commit details
    Browse the repository at this point in the history
Loading