Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Use libtiledbsoma handles for arrays #3059

Closed
johnkerl opened this issue Sep 24, 2024 · 2 comments
Closed

[r] Use libtiledbsoma handles for arrays #3059

johnkerl opened this issue Sep 24, 2024 · 2 comments
Assignees

Comments

@johnkerl
Copy link
Member

johnkerl commented Sep 24, 2024

Already done for groups

#2406; [sc-55685].

Steps:

  • Status quo is
    • There is a private$.tiledb_array with connection to self$object
      • This is set on construction/open, and closed on close
    • The libtiledbsoma handles are currently ephemeral
      • Every read / write / get_metadata etc which is libtiledbsoma-capable currently takes a uri and a ctx and does open/op/close
  • Needing to be done:

To check:

  • Currently the array set_metadata does not error out when the array is opened for read -- this is a bug.
    • This should be auto-fixed by this issue, but, it needs to be tested.
@johnkerl johnkerl changed the title [r] Use clib handles for arrays [r] Use libtiledbsoma handles for arrays Oct 3, 2024
@johnkerl johnkerl self-assigned this Oct 10, 2024
@johnkerl
Copy link
Member Author

Blocked by #3051 since here
https://github.com/single-cell-data/TileDB-SOMA/blob/1.15.0rc2/apis/r/R/SOMADataFrame.R#L182
the self$object is used. Removing that private$.tiledb_array / self$object from the base class TileDBArray.R causes this query-condition logic to return empty results, in a way that makes unit-test cases fail in non-obvious ways.

We need to move the query-condition logic over from TileDB-R before we can continue here.

@johnkerl
Copy link
Member Author

This is a duplicate of #3061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant