From 3f1a3f01f4bb1448997d0ef71ad4ad7ec08506d2 Mon Sep 17 00:00:00 2001 From: John Kerl Date: Thu, 3 Oct 2024 12:04:47 -0400 Subject: [PATCH] fix unit-test failures --- apis/r/R/SOMADataFrame.R | 4 ++++ apis/r/tests/testthat/test-SOMADataFrame.R | 1 + 2 files changed, 5 insertions(+) diff --git a/apis/r/R/SOMADataFrame.R b/apis/r/R/SOMADataFrame.R index b560023d20..691381a075 100644 --- a/apis/r/R/SOMADataFrame.R +++ b/apis/r/R/SOMADataFrame.R @@ -245,6 +245,10 @@ SOMADataFrame <- R6::R6Class( is.data.frame(values) || is_arrow_table(values) || is_arrow_record_batch(values) ) + # Leave state unmodified + # TODO: this issue will automatically go away on https://github.com/single-cell-data/TileDB-SOMA/issues/3059 + on.exit(self$reopen(mode = "WRITE")) + if (is.data.frame(values)) { if (!is.null(row_index_name)) { stopifnot( diff --git a/apis/r/tests/testthat/test-SOMADataFrame.R b/apis/r/tests/testthat/test-SOMADataFrame.R index d7fd0879e5..64a8334acd 100644 --- a/apis/r/tests/testthat/test-SOMADataFrame.R +++ b/apis/r/tests/testthat/test-SOMADataFrame.R @@ -745,6 +745,7 @@ test_that("SOMADataFrame can be updated", { ) tbl0 <- tbl1 + # Error on incompatible schema updates tbl0$string_column <- tbl0$string_column$cast(target_type = arrow::int32()) # string to int expect_error(