Solves code warnings

mrjato · mrjato · commit b8eb360893e1 · 2023-07-12T18:50:01.000+02:00
Code warning, mainly caused by unused imports, have been fixed.
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/cli/command/GenerateDistributableCommand.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/cli/command/GenerateDistributableCommand.java
@@ -27,23 +27,36 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
-import java.util.ArrayList;
 
+import org.apache.commons.lang3.tuple.ImmutablePair;
+import org.apache.commons.lang3.tuple.Pair;
+import org.apache.maven.model.Model;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import ch.qos.logback.classic.Level;
 import ch.qos.logback.classic.LoggerContext;
 import es.uvigo.ei.sing.yacli.command.AbstractCommand;
+import es.uvigo.ei.sing.yacli.command.option.DefaultValuedStringOption;
 import es.uvigo.ei.sing.yacli.command.option.EnumOption;
 import es.uvigo.ei.sing.yacli.command.option.FlagOption;
 import es.uvigo.ei.sing.yacli.command.option.Option;
 import es.uvigo.ei.sing.yacli.command.option.StringOption;
 import es.uvigo.ei.sing.yacli.command.parameter.Parameters;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.DirectoryOption;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.FileWithExtensionOption;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.JavaClassNameOption;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.MavenCoordinateOption;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.POMFileWithExtensionOption;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.UrlOption;
+import es.uvigo.esei.sing.java_to_distributable.cli.option.XMLFileWithExtensionOption;
 import es.uvigo.esei.sing.java_to_distributable.enums.JavaVersionEnum;
 import es.uvigo.esei.sing.java_to_distributable.enums.OptionCategoryEnum;
+import es.uvigo.esei.sing.java_to_distributable.exceptions.UnableToResolveArtifactException;
+import es.uvigo.esei.sing.java_to_distributable.factories.MavenAppLoaderFactory;
 import es.uvigo.esei.sing.java_to_distributable.loaders.AppLoader;
 import es.uvigo.esei.sing.java_to_distributable.loaders.JarAppLoader;
 import es.uvigo.esei.sing.java_to_distributable.model.AppInfo;
@@ -54,22 +67,6 @@
 import es.uvigo.esei.sing.java_to_distributable.provider.ParametersAppInfoProvider;
 import es.uvigo.esei.sing.java_to_distributable.utils.output.OutputGenerator;
 import es.uvigo.esei.sing.java_to_distributable.utils.validators.ParamValidator;
-import es.uvigo.esei.sing.java_to_distributable.cli.option.XMLFileWithExtensionOption;
-import es.uvigo.esei.sing.java_to_distributable.exceptions.UnableToResolveArtifactException;
-import es.uvigo.esei.sing.java_to_distributable.factories.MavenAppLoaderFactory;
-
-import org.apache.commons.lang3.tuple.ImmutablePair;
-import org.apache.commons.lang3.tuple.Pair;
-import org.apache.maven.model.Model;
-
-import es.uvigo.ei.sing.yacli.command.option.DefaultValuedStringOption;
-
-import es.uvigo.esei.sing.java_to_distributable.cli.option.DirectoryOption;
-import es.uvigo.esei.sing.java_to_distributable.cli.option.FileWithExtensionOption;
-import es.uvigo.esei.sing.java_to_distributable.cli.option.JavaClassNameOption;
-import es.uvigo.esei.sing.java_to_distributable.cli.option.MavenCoordinateOption;
-import es.uvigo.esei.sing.java_to_distributable.cli.option.POMFileWithExtensionOption;
-import es.uvigo.esei.sing.java_to_distributable.cli.option.UrlOption;
 
 /**
  * 
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/cli/converter/FileWithExtensionConverter.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/cli/converter/FileWithExtensionConverter.java
@@ -22,6 +22,7 @@
 package es.uvigo.esei.sing.java_to_distributable.cli.converter;
 
 import java.io.File;
+import java.nio.file.Paths;
 import java.util.List;
 
 import es.uvigo.ei.sing.yacli.command.option.AbstractOptionConverter;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/loaders/JarAppLoader.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/loaders/JarAppLoader.java
@@ -26,9 +26,7 @@
 package es.uvigo.esei.sing.java_to_distributable.loaders;
 
 import java.io.File;
-import java.lang.reflect.Constructor;
 import java.net.URL;
-import java.net.URLClassLoader;
 import java.nio.file.Path;
 import java.util.List;
 import java.util.stream.Collectors;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/loaders/maven/MavenAppLoader.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/loaders/maven/MavenAppLoader.java
@@ -22,7 +22,6 @@
 package es.uvigo.esei.sing.java_to_distributable.loaders.maven;
 
 import java.io.File;
-
 import java.net.URL;
 import java.nio.file.Path;
 import java.util.ArrayList;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/loaders/maven/POMProvidedMavenAppLoader.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/loaders/maven/POMProvidedMavenAppLoader.java
@@ -26,8 +26,8 @@
 
 import java.io.File;
 
-import org.apache.maven.model.Model;
 import org.apache.commons.lang3.tuple.Pair;
+import org.apache.maven.model.Model;
 import org.jboss.shrinkwrap.resolver.api.maven.ConfigurableMavenResolverSystem;
 import org.jboss.shrinkwrap.resolver.api.maven.Maven;
 import org.jboss.shrinkwrap.resolver.api.maven.MavenResolvedArtifact;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/mapper/Mapper.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/mapper/Mapper.java
@@ -39,19 +39,19 @@
  *
  */
 public abstract class Mapper<K, V> {
-  
+
   protected Map<K, V> map;
-  
+
   protected final Formatter<K, V> formatter;
-  
-  public Mapper (Formatter formatter) {
+
+  public Mapper(Formatter<K, V> formatter) {
     this.map = new HashMap<K, V>();
     this.formatter = formatter;
   }
 
   /**
-   * Abstract method to be implemented by subclasses for populating the
-   * map with data.
+   * Abstract method to be implemented by subclasses for populating the map with
+   * data.
    *
    *
    */
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/model/AppInfo.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/model/AppInfo.java
@@ -30,7 +30,6 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/provider/MavenAppInfoProvider.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/provider/MavenAppInfoProvider.java
@@ -30,7 +30,6 @@
 import java.util.Objects;
 
 import org.apache.maven.model.Model;
-import org.apache.velocity.runtime.directive.Foreach;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/output/DebianAppOutputGenerator.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/output/DebianAppOutputGenerator.java
@@ -24,8 +24,11 @@
 
 import java.io.BufferedReader;
 import java.io.File;
+import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.io.OutputStream;
 import java.net.URL;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -39,8 +42,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.*;
-
 import es.uvigo.esei.sing.java_to_distributable.formatter.DebianAppInfoFormatter;
 import es.uvigo.esei.sing.java_to_distributable.mapper.AppInfoMapper;
 import es.uvigo.esei.sing.java_to_distributable.mapper.Mapper;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/output/FileGenerator.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/output/FileGenerator.java
@@ -26,8 +26,6 @@
 package es.uvigo.esei.sing.java_to_distributable.utils.output;
 
 import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileNotFoundException;
 import java.io.FileWriter;
 import java.io.IOException;
 import java.io.InputStream;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/output/RPMAppOutputGenerator.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/output/RPMAppOutputGenerator.java
@@ -33,26 +33,22 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
-import java.io.OutputStream;
 import java.net.URL;
-import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.nio.file.StandardCopyOption;
-import java.nio.file.attribute.BasicFileAttributes;
 import java.util.Arrays;
 import java.util.Comparator;
 import java.util.List;
 import java.util.Map;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
 import org.apache.commons.compress.archivers.tar.TarArchiveOutputStream;
 import org.apache.commons.compress.compressors.gzip.GzipCompressorOutputStream;
 import org.apache.commons.compress.utils.IOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import es.uvigo.esei.sing.java_to_distributable.formatter.RPMAppInfoFormatter;
 import es.uvigo.esei.sing.java_to_distributable.mapper.AppInfoMapper;
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/validators/ParamValidator.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/validators/ParamValidator.java
@@ -24,9 +24,10 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.tuple.Pair;
+
 import es.uvigo.ei.sing.yacli.command.option.Option;
 import es.uvigo.ei.sing.yacli.command.parameter.Parameters;
-import org.apache.commons.lang3.tuple.Pair;
 
 /**
  * A class that provides methods for validating {@link Parameters}.
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/xml/pom/POMFormatterContentHandler.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/xml/pom/POMFormatterContentHandler.java
@@ -26,14 +26,13 @@
 import java.io.Writer;
 import java.util.Objects;
 
+import org.apache.commons.lang3.tuple.Pair;
 import org.jboss.shrinkwrap.resolver.api.maven.coordinate.MavenCoordinate;
 import org.jboss.shrinkwrap.resolver.api.maven.coordinate.MavenCoordinates;
 import org.xml.sax.Attributes;
 import org.xml.sax.SAXException;
 import org.xml.sax.helpers.DefaultHandler;
 
-import org.apache.commons.lang3.tuple.Pair;
-
 /**
  * This class extends the {@link org.xml.sax.helpers.DefaultHandler} and
  * overrides its methods to parse and format Maven's POM (Project Object Model)
diff --git a/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/xml/pom/POMParser.java b/src/main/java/es/uvigo/esei/sing/java_to_distributable/utils/xml/pom/POMParser.java
@@ -29,12 +29,11 @@
 
 import javax.xml.parsers.ParserConfigurationException;
 
+import org.apache.commons.lang3.tuple.MutablePair;
+import org.apache.commons.lang3.tuple.Pair;
 import org.jboss.shrinkwrap.resolver.api.maven.coordinate.MavenCoordinate;
 import org.xml.sax.SAXException;
 
-import org.apache.commons.lang3.tuple.Pair;
-import org.apache.commons.lang3.tuple.MutablePair;
-
 import es.uvigo.esei.sing.java_to_distributable.utils.xml.SAXParsing;
 
 /**
