Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Join type #235

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Add Join type #235

merged 1 commit into from
Sep 5, 2021

Conversation

avaly
Copy link
Contributor

@avaly avaly commented Jul 29, 2021

This type is useful for advanced types when defining field paths in a nested object (e.g. for dot-notation fields in MongoDB queries).

sindresorhus
sindresorhus reviewed Jul 31, 2021
View reviewed changes
ts41/join.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

If there has been any discussion somewhere about this type, include a link to it. For example, a discussion on the TypeScript issue tracker. - https://github.com/sindresorhus/type-fest/blob/main/.github/contributing.md

@avaly avaly requested a review from sindresorhus August 4, 2021 05:48
@sindresorhus
Copy link
Owner

#235 (comment)

^

@avaly
Copy link
Contributor Author

avaly commented Aug 24, 2021

Initially discussed in microsoft/TypeScript#40336

@sindresorhus sindresorhus merged commit e9e5665 into sindresorhus:main Sep 5, 2021
@avaly avaly deleted the feature/Join branch September 6, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avaly @sindresorhus