Skip to content

Add code frame #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add code frame #19

merged 1 commit into from
Jul 2, 2019

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Oct 21, 2018

I find it easier to locate the error with a than just the index of the error. E.g. trailing comma in an object:

image

Note: This drops support for node 4

I left out tests in case you don't want this

@SimenB
Copy link
Contributor Author

SimenB commented Oct 21, 2018

Fixed the linting error I introduced, what should I do about the other ones?

@sindresorhus
Copy link
Owner

I totally missed this one... Can you fix the merge conflict?

You also need to update the readme.

Maybe also an example.js that shows how the output looks like with the code frame.

@sindresorhus sindresorhus changed the title feat: add code frame Add code frame Jun 29, 2019
@SimenB
Copy link
Contributor Author

SimenB commented Jun 29, 2019

Maybe also an example.js that shows how the output looks like with the code frame.

The updated readme shows this (albeit without colors), do you want anything more?

@sindresorhus sindresorhus merged commit 06d9a8c into sindresorhus:master Jul 2, 2019
@sindresorhus
Copy link
Owner

Looks good :)

@SimenB SimenB deleted the add-codeframe branch July 2, 2019 18:06
SmushyTaco pushed a commit to SmushyTaco/parse-json that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants