Support Node 22 and drop Node <18.17.0 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs tests on Node 22.
Node 22 uses a new default value for
highWaterMark: 64KB instead of 16KB. (nodejs/node#52037). We should keep the default value. This means we need to usestream.getDefaultHighWaterMark().However, that method was introduced in
18.17.0. We had some issues a couple of months ago with using that method: #16.Therefore, I think we might want to do a major release to avoid that same issue, i.e. where we explicitly state that we drop support for Node <18.17.0.