Add TODO comment about spawned.stdin bug being fixed in Node.js 12#258
Merged
sindresorhus merged 2 commits intomasterfrom May 20, 2019
Merged
Add TODO comment about spawned.stdin bug being fixed in Node.js 12#258sindresorhus merged 2 commits intomasterfrom
spawned.stdin bug being fixed in Node.js 12#258sindresorhus merged 2 commits intomasterfrom
Conversation
sindresorhus
changed the title
spawned.stdin bug being fixed in Node 12spawned.stdin bug being fixed in Node.js 12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#212 will not be needed anymore after the next release of Node.js (
12.3.0probably). This was fixed in Node.js by this PR.This adds a
TODOcomment to remove it once we drop support for Node.js<= 12.2.0. Granted this won't be in the immediate future :)