Auto generate rule notice #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
reviewed
Jan 4, 2022
scripts/utils.mjs
Outdated
| export const RULE_NOTICE_END_MARK = '<!-- RULE_NOTICE_END -->'; | ||
|
|
||
| const recommendedRules = getRecommendedRules(); | ||
| export function getRuleNotice(id) { |
There was a problem hiding this comment.
It's a bit odd that this has "notice" singular in the name given it can include multiple notices. Maybe call it getRuleNoticesSectionBody to indicate it returns potentially multiple lines of notices?
scripts/generate-rule-notice.mjs
Outdated
|
|
||
| const rules = Object.entries(eslintPluginUnicorn.rules).filter(([, rule]) => !rule.meta.deprecated).map(([id]) => id); | ||
|
|
||
| async function updateNotice(id) { |
There was a problem hiding this comment.
Naming for better clarity?
Suggested change
| async function updateNotice(id) { | |
| async function updateNotices(ruleId) { |
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
bmish
approved these changes
Jan 5, 2022
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.