-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Haxe Game Development #1573
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Some missing items:
The list doesn't follow the formatting specified in the PR template, but maybe a table is OK? |
The guidelines says
Updated.
Damn it, just changed it.
I don't get this one. |
Sorry, I didn't mean to include "Awesome" in my comment. Based on the examples in the instructions, I think "name of list" refers to the part that comes after "Awesome". What I meant to say was, the name of the list is inconsistent between the list repo's README, the PR, and the commit to the list:
So pick either "Gamedev" or "Gamer Development" instead of using both. |
Ok went for "Haxe Game Development" for those three. |
unicorn |
The description of Haxe in your readme should be slightly more descriptive than just:
Explain why it's awesome for game development. Also linkify the word |
Updated those 3 requests from sindresorhus. https://github.com/Dvergar/awesome-haxe-gamedev/tree/06e4c9daa9d69631396ad940a699f774c1c43bff |
There are still inconsistencies. Like Not clear what Don't include useless stuff, for example:
It has absolutely no information. |
This is a good list with precious resources, but I find it somewhat confusing to read through, its format is very different than most awesome lists, including the root one.
These are mostly formatting issues, but the content of the list seems good! I'm a big fan of Haxe, so I hope to see this list improved in the future. 😄 |
https://github.com/rafaskb/awesome-libgdx#readme LibGDX is a powerful game framework in Java, similar to the one used by Minecraft. This list is a curated collection of resources, add-ons, and guides to help LibGDX developers make awesome games. ----- ✅ By submitting this pull request I confirm I've read and complied with the below requirements 🖖 ✅ Review at least 2 other open pull requests ✅ - PR Review 1: sindresorhus#1589 (comment) ✅ - PR Review 2: sindresorhus#1573 (comment) ✅ Pull request's title follows the requested format. ✅ Include a short description about the project/theme of the list. ✅ Your entry should be added at the bottom of the appropriate category. ✅ Your list has been around for at least 30 days. ✅ Run awesome-lint and fix the reported issues. (Other than the false positives.) ✅ The repo name of your list should be in lowercase slug format. ✅ The heading title of your list should be in title case format. ✅ Non-generated Markdown file in a GitHub repo. ✅ The repo should have awesome-list & awesome as GitHub topics. ✅ Not a duplicate. Please search for existing submissions. ✅ Only has awesome items. Awesome lists are curations of the best, not everything. ✅ Includes a project logo/illustration whenever possible. ✅ Entries have a description. ✅ Includes the Awesome badge. ✅ Has a Table of Contents section. ✅ Has an appropriate license. (CC0) ✅ Has contribution guidelines. ✅ Has consistent formatting and proper spelling/grammar. ✅ Doesn't include a Travis badge. ✅ Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme.
Fixed all of these.
Changed it to "small".
Agreed, updated.
I think I read that a specific resolution was needed and that half that size had to be set.
We already discussed it earlier.
Haxe 4 was a little bit in some python2 vs python3 situation so i felt it was needed to be aware of the situation library-wise.
The idea was actually the opposite, readability. If a new layout is really required i can change it but is it really ? I felt like "doc" was actually a relevant information.
I'm not listing everything, for some really niche categories i dig a bit further, but my requirements for listing something is, my own experience, the popularity of the library, freshness and legacy when it's relevant. My list isn't supposed to be static, i'm updating it, i give some libraries a chance and if it's abandoned, it's removed. "Unmaintained" for me just means that it has been a big library and that it's relevant for study purpose. |
No, there are still more. For example,
There should be no And if you don't have the
This is not consistently followed.
Don't mention the library name in the description. This could be:
Same applies to many other descriptions.
You don't have to "think you read". The requirements are right at the top of this thread:
So in this case, center it (while still having it half width, of course). I agree with the other commenter. Haxe 3 is not the purpose of this list. If you want to mention Haxe 3 resources, I think you should create a separate Markdown file for that. It could have the same structure and categories, but only Haxe 3 stuff. Generally, I think this list needs more work. |
I kept the table but i'm willing to change the layout if necessary. |
https://github.com/dvergar/awesome-haxe-gamedev
This is a list of resources for game development in the haxe language.
PR Review 1 : #1563 (comment)
PR Review 2 : #1538 (comment)
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
# Awesome Name of List
# Awesome Swift
# Awesome Web Typography
# awesome-swift
#
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.