-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS and Mac OS Security #1538
Conversation
|
The following points are missing or are not as per guidelines.
|
In addition to what @teoga mentioned, this one is also missing:
|
@streichsbaer I am adding immediately after the Android security link and it seems like the best place to me. |
I fixed all the issues except the following
I am not sure why "Missing Awesome badge after the main heading remark-lint:awesome/badge" is happening when I have the badge. For the other two errors, I cannot change "OS X" to "macOS" since those two product names use "OS X" in their respective names. |
Not sure how jailbreak links relate to iOS/Mac security tools in the list - something to consider. |
Why do you think so, wouldn't security researchers be interested in jailbreaking tools as well? |
@ashishb IMO it's not directly related to security tools, but again - personal opinion. |
As of today the log of awesome-lint is
To answer your badge question, it's probably because you're using an old or different badge link. |
@Dvergar Thanks for the review.
|
There are still many things in the guidelines that are not followed. |
@sindresorhus This isn't very helpful. If you spotted something you might as point it out here in the comments. |
Missing requirements I noticed:
|
It's not very helpful that nobody properly reads the guidelines either. I've spent countless of hours on them and I still have to mostly just copy-paste half of it as comments in every single PR. |
[Insert URL to the list here]
https://github.com/ashishb/osx-and-ios-security-awesome
[Explain what this list is about and why it should be included here]
It is about iOS and Mac OS security tools
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Add Name of List
(Example:Add Swift
), notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Go to the top and read it again.