Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of ruby2_keywords, only use it for blocks which delegate #130

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fix usage of ruby2_keywords, only use it for blocks which delegate #130

merged 1 commit into from
Jul 19, 2022

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Jul 19, 2022 •
edited
Loading

Address the issue reported in #128.

bundle exec rake has no ruby2_keywords warnings with this.

This was referenced Jul 19, 2022
Closed
Merged
@jkowens
Copy link
Member

jkowens commented Jul 19, 2022

Fantastic, thank you @eregon!

@jkowens jkowens merged commit 37135cc into sinatra:master Jul 19, 2022
@eregon eregon deleted the fix-ruby2_keywords-usage branch July 19, 2022 14:25
@jkowens
Copy link
Member

jkowens commented Jul 19, 2022

Released in v2.0.1

@gazayas gazayas mentioned this pull request Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eregon @jkowens