Skip to content

Commit 247ff47

Browse files
authored
Merge pull request #909 from simvue-io/kzscisoft/config-deprecation-and-test-fixes
Kzscisoft/config deprecation and test fixes
2 parents b31e479 + f291ccc commit 247ff47

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

simvue/config/user.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
import toml
1717
import semver
1818

19+
try:
20+
from typing import Self
21+
except ImportError:
22+
from typing_extensions import Self
23+
1924
import simvue.utilities as sv_util
2025
from simvue.config.parameters import (
2126
ClientGeneralOptions,
@@ -138,14 +143,13 @@ def write(self, out_directory: pydantic.DirectoryPath) -> None:
138143
toml.dump(self.model_dump(), out_f)
139144

140145
@pydantic.model_validator(mode="after")
141-
@classmethod
142-
def check_valid_server(cls, values: "SimvueConfiguration") -> "SimvueConfiguration":
146+
def check_valid_server(self) -> Self:
143147
if os.environ.get("SIMVUE_NO_SERVER_CHECK"):
144-
return values
148+
return self
145149

146-
cls._check_server(values.server.token, values.server.url, values.run.mode)
150+
self._check_server(self.server.token, self.server.url, self.run.mode)
147151

148-
return values
152+
return self
149153

150154
@classmethod
151155
@sv_util.prettify_pydantic

tests/unit/test_metadata.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ def test_python_env(backend: str | None) -> None:
3030
else:
3131
metadata = sv_meta._python_env(pathlib.Path(__file__).parents[1].joinpath("example_data"))
3232

33-
assert re.findall(r"\d+\.\d+\.\d+", metadata["environment"]["numpy"])
33+
if backend:
34+
assert re.findall(r"\d+\.\d+\.\d+", metadata["environment"]["numpy"])
3435

3536

3637
@pytest.mark.metadata

0 commit comments

Comments
 (0)