fix(oauth): evict CIMD cache on upsert failure to allow retry

Author: waleedlatif1

apps/sim/lib/auth/auth.ts

@@ -25,7 +25,12 @@ import {
   renderPasswordResetEmail,
   renderWelcomeEmail,
 } from '@/components/emails'
-import { isMetadataUrl, resolveClientMetadata, upsertCimdClient } from '@/lib/auth/cimd'
+import {
+  evictCachedMetadata,
+  isMetadataUrl,
+  resolveClientMetadata,
+  upsertCimdClient,
+} from '@/lib/auth/cimd'
 import { sendPlanWelcomeEmail } from '@/lib/billing'
 import { authorizeSubscriptionReference } from '@/lib/billing/authorization'
 import { handleNewUser } from '@/lib/billing/core/usage'
@@ -548,7 +553,12 @@ export const auth = betterAuth({
           try {
             const { metadata, fromCache } = await resolveClientMetadata(clientId)
             if (!fromCache) {
-              await upsertCimdClient(metadata)
+              try {
+                await upsertCimdClient(metadata)
+              } catch (upsertErr) {
+                evictCachedMetadata(clientId)
+                throw upsertErr
+              }
             }
           } catch (err) {
             logger.warn('CIMD resolution failed', {

apps/sim/lib/auth/cimd.ts

@@ -127,6 +127,10 @@ export async function resolveClientMetadata(url: string): Promise<ResolveResult>
   return promise.then((doc) => ({ metadata: doc, fromCache: false }))
 }
 
+export function evictCachedMetadata(url: string): void {
+  cache.delete(url)
+}
+
 export async function upsertCimdClient(metadata: ClientMetadataDocument): Promise<void> {
   const now = new Date()
   const redirectURLs = metadata.redirect_uris.join(',')