fix(kb): remove non-null assertion, add explicit guard

waleedlatif1 · waleedlatif1 · commit 9009a291f186 · 2026-01-22T19:21:46.000-08:00
diff --git a/apps/sim/app/api/knowledge/[id]/documents/route.ts b/apps/sim/app/api/knowledge/[id]/documents/route.ts
@@ -346,8 +346,10 @@ export async function PATCH(req: NextRequest, { params }: { params: Promise<{ id
             enabledFilter,
             requestId
           )
+        } else if (documentIds && documentIds.length > 0) {
+          result = await bulkDocumentOperation(knowledgeBaseId, operation, documentIds, requestId)
         } else {
-          result = await bulkDocumentOperation(knowledgeBaseId, operation, documentIds!, requestId)
+          return NextResponse.json({ error: 'No documents specified' }, { status: 400 })
         }
 
         return NextResponse.json({

Original file line number	Diff line number	Diff line change
`@@ -346,8 +346,10 @@ export async function PATCH(req: NextRequest, { params }: { params: Promise<{ id`
`346`	`346`	`enabledFilter,`
`347`	`347`	`requestId`
`348`	`348`	`)`
	`349`	`+ } else if (documentIds && documentIds.length > 0) {`
	`350`	`+ result = await bulkDocumentOperation(knowledgeBaseId, operation, documentIds, requestId)`
`349`	`351`	`} else {`
`350`		`- result = await bulkDocumentOperation(knowledgeBaseId, operation, documentIds!, requestId)`
	`352`	`+ return NextResponse.json({ error: 'No documents specified' }, { status: 400 })`
`351`	`353`	`}`
`352`	`354`
`353`	`355`	`return NextResponse.json({`