improvement(google-contacts): add advanced mode, error handling, and input trimming

waleedlatif1 · waleedlatif1 · commit 8b676a51442d · 2026-02-27T10:45:51.000-08:00
- Set mode: 'advanced' on optional fields (emailType, phoneType, notes, pageSize, pageToken, sortOrder)
- Add createLogger and response.ok error handling to all 6 tools
- Add .trim() on resourceName in get, update, delete URL builders
diff --git a/apps/sim/blocks/blocks/google_contacts.ts b/apps/sim/blocks/blocks/google_contacts.ts
@@ -84,6 +84,7 @@ export const GoogleContactsBlock: BlockConfig<GoogleContactsResponse> = {
         { label: 'Other', id: 'other' },
       ],
       value: () => 'work',
+      mode: 'advanced',
     },
     {
       id: 'phone',
@@ -104,6 +105,7 @@ export const GoogleContactsBlock: BlockConfig<GoogleContactsResponse> = {
         { label: 'Other', id: 'other' },
       ],
       value: () => 'mobile',
+      mode: 'advanced',
     },
     {
       id: 'organization',
@@ -125,6 +127,7 @@ export const GoogleContactsBlock: BlockConfig<GoogleContactsResponse> = {
       type: 'long-input',
       placeholder: 'Additional notes about the contact',
       condition: { field: 'operation', value: ['create', 'update'] },
+      mode: 'advanced',
     },
 
     // Get / Update / Delete Fields
@@ -164,13 +167,15 @@ export const GoogleContactsBlock: BlockConfig<GoogleContactsResponse> = {
       type: 'short-input',
       placeholder: '100',
       condition: { field: 'operation', value: ['list', 'search'] },
+      mode: 'advanced',
     },
     {
       id: 'pageToken',
       title: 'Page Token',
       type: 'short-input',
       placeholder: 'Token from previous list request',
       condition: { field: 'operation', value: 'list' },
+      mode: 'advanced',
     },
     {
       id: 'sortOrder',
@@ -184,6 +189,7 @@ export const GoogleContactsBlock: BlockConfig<GoogleContactsResponse> = {
         { label: 'Last Name (Ascending)', id: 'LAST_NAME_ASCENDING' },
       ],
       value: () => 'LAST_MODIFIED_DESCENDING',
+      mode: 'advanced',
     },
   ],
   tools: {
diff --git a/apps/sim/tools/google_contacts/create.ts b/apps/sim/tools/google_contacts/create.ts
@@ -1,3 +1,4 @@
+import { createLogger } from '@sim/logger'
 import {
   DEFAULT_PERSON_FIELDS,
   type GoogleContactsCreateParams,
@@ -7,6 +8,8 @@ import {
 } from '@/tools/google_contacts/types'
 import type { ToolConfig } from '@/tools/types'
 
+const logger = createLogger('GoogleContactsCreate')
+
 export const createTool: ToolConfig<GoogleContactsCreateParams, GoogleContactsCreateResponse> = {
   id: 'google_contacts_create',
   name: 'Google Contacts Create',
@@ -125,6 +128,13 @@ export const createTool: ToolConfig<GoogleContactsCreateParams, GoogleContactsCr
 
   transformResponse: async (response: Response) => {
     const data = await response.json()
+
+    if (!response.ok) {
+      const errorMessage = data.error?.message || 'Failed to create contact'
+      logger.error('Failed to create contact', { status: response.status, error: errorMessage })
+      throw new Error(errorMessage)
+    }
+
     const contact = transformPerson(data)
 
     return {
diff --git a/apps/sim/tools/google_contacts/delete.ts b/apps/sim/tools/google_contacts/delete.ts
@@ -1,10 +1,13 @@
+import { createLogger } from '@sim/logger'
 import {
   type GoogleContactsDeleteParams,
   type GoogleContactsDeleteResponse,
   PEOPLE_API_BASE,
 } from '@/tools/google_contacts/types'
 import type { ToolConfig } from '@/tools/types'
 
+const logger = createLogger('GoogleContactsDelete')
+
 export const deleteTool: ToolConfig<GoogleContactsDeleteParams, GoogleContactsDeleteResponse> = {
   id: 'google_contacts_delete',
   name: 'Google Contacts Delete',
@@ -33,7 +36,7 @@ export const deleteTool: ToolConfig<GoogleContactsDeleteParams, GoogleContactsDe
 
   request: {
     url: (params: GoogleContactsDeleteParams) =>
-      `${PEOPLE_API_BASE}/${params.resourceName}:deleteContact`,
+      `${PEOPLE_API_BASE}/${params.resourceName.trim()}:deleteContact`,
     method: 'DELETE',
     headers: (params: GoogleContactsDeleteParams) => ({
       Authorization: `Bearer ${params.accessToken}`,
@@ -56,7 +59,9 @@ export const deleteTool: ToolConfig<GoogleContactsDeleteParams, GoogleContactsDe
     }
 
     const errorData = await response.json()
-    throw new Error(errorData.error?.message || 'Failed to delete contact')
+    const errorMessage = errorData.error?.message || 'Failed to delete contact'
+    logger.error('Failed to delete contact', { status: response.status, error: errorMessage })
+    throw new Error(errorMessage)
   },
 
   outputs: {
diff --git a/apps/sim/tools/google_contacts/get.ts b/apps/sim/tools/google_contacts/get.ts
@@ -1,3 +1,4 @@
+import { createLogger } from '@sim/logger'
 import {
   DEFAULT_PERSON_FIELDS,
   type GoogleContactsGetParams,
@@ -7,6 +8,8 @@ import {
 } from '@/tools/google_contacts/types'
 import type { ToolConfig } from '@/tools/types'
 
+const logger = createLogger('GoogleContactsGet')
+
 export const getTool: ToolConfig<GoogleContactsGetParams, GoogleContactsGetResponse> = {
   id: 'google_contacts_get',
   name: 'Google Contacts Get',
@@ -35,7 +38,7 @@ export const getTool: ToolConfig<GoogleContactsGetParams, GoogleContactsGetRespo
 
   request: {
     url: (params: GoogleContactsGetParams) =>
-      `${PEOPLE_API_BASE}/${params.resourceName}?personFields=${DEFAULT_PERSON_FIELDS}`,
+      `${PEOPLE_API_BASE}/${params.resourceName.trim()}?personFields=${DEFAULT_PERSON_FIELDS}`,
     method: 'GET',
     headers: (params: GoogleContactsGetParams) => ({
       Authorization: `Bearer ${params.accessToken}`,
@@ -45,6 +48,13 @@ export const getTool: ToolConfig<GoogleContactsGetParams, GoogleContactsGetRespo
 
   transformResponse: async (response: Response) => {
     const data = await response.json()
+
+    if (!response.ok) {
+      const errorMessage = data.error?.message || 'Failed to get contact'
+      logger.error('Failed to get contact', { status: response.status, error: errorMessage })
+      throw new Error(errorMessage)
+    }
+
     const contact = transformPerson(data)
 
     return {
diff --git a/apps/sim/tools/google_contacts/list.ts b/apps/sim/tools/google_contacts/list.ts
@@ -1,3 +1,4 @@
+import { createLogger } from '@sim/logger'
 import {
   DEFAULT_PERSON_FIELDS,
   type GoogleContactsListParams,
@@ -7,6 +8,8 @@ import {
 } from '@/tools/google_contacts/types'
 import type { ToolConfig } from '@/tools/types'
 
+const logger = createLogger('GoogleContactsList')
+
 export const listTool: ToolConfig<GoogleContactsListParams, GoogleContactsListResponse> = {
   id: 'google_contacts_list',
   name: 'Google Contacts List',
@@ -65,6 +68,13 @@ export const listTool: ToolConfig<GoogleContactsListParams, GoogleContactsListRe
 
   transformResponse: async (response: Response) => {
     const data = await response.json()
+
+    if (!response.ok) {
+      const errorMessage = data.error?.message || 'Failed to list contacts'
+      logger.error('Failed to list contacts', { status: response.status, error: errorMessage })
+      throw new Error(errorMessage)
+    }
+
     const connections = data.connections || []
     const contacts = connections.map((person: Record<string, any>) => transformPerson(person))
 
diff --git a/apps/sim/tools/google_contacts/search.ts b/apps/sim/tools/google_contacts/search.ts
@@ -1,3 +1,4 @@
+import { createLogger } from '@sim/logger'
 import {
   DEFAULT_PERSON_FIELDS,
   type GoogleContactsSearchParams,
@@ -7,6 +8,8 @@ import {
 } from '@/tools/google_contacts/types'
 import type { ToolConfig } from '@/tools/types'
 
+const logger = createLogger('GoogleContactsSearch')
+
 export const searchTool: ToolConfig<GoogleContactsSearchParams, GoogleContactsSearchResponse> = {
   id: 'google_contacts_search',
   name: 'Google Contacts Search',
@@ -58,6 +61,13 @@ export const searchTool: ToolConfig<GoogleContactsSearchParams, GoogleContactsSe
 
   transformResponse: async (response: Response) => {
     const data = await response.json()
+
+    if (!response.ok) {
+      const errorMessage = data.error?.message || 'Failed to search contacts'
+      logger.error('Failed to search contacts', { status: response.status, error: errorMessage })
+      throw new Error(errorMessage)
+    }
+
     const results = data.results || []
     const contacts = results.map((result: Record<string, any>) =>
       transformPerson(result.person || result)
diff --git a/apps/sim/tools/google_contacts/update.ts b/apps/sim/tools/google_contacts/update.ts
@@ -1,3 +1,4 @@
+import { createLogger } from '@sim/logger'
 import {
   DEFAULT_PERSON_FIELDS,
   type GoogleContactsUpdateParams,
@@ -7,6 +8,8 @@ import {
 } from '@/tools/google_contacts/types'
 import type { ToolConfig } from '@/tools/types'
 
+const logger = createLogger('GoogleContactsUpdate')
+
 export const updateTool: ToolConfig<GoogleContactsUpdateParams, GoogleContactsUpdateResponse> = {
   id: 'google_contacts_update',
   name: 'Google Contacts Update',
@@ -108,7 +111,7 @@ export const updateTool: ToolConfig<GoogleContactsUpdateParams, GoogleContactsUp
 
       const updatePersonFields = updateFields.join(',')
 
-      return `${PEOPLE_API_BASE}/${params.resourceName}:updateContact?updatePersonFields=${updatePersonFields}&personFields=${DEFAULT_PERSON_FIELDS}`
+      return `${PEOPLE_API_BASE}/${params.resourceName.trim()}:updateContact?updatePersonFields=${updatePersonFields}&personFields=${DEFAULT_PERSON_FIELDS}`
     },
     method: 'PATCH',
     headers: (params: GoogleContactsUpdateParams) => ({
@@ -156,6 +159,13 @@ export const updateTool: ToolConfig<GoogleContactsUpdateParams, GoogleContactsUp
 
   transformResponse: async (response: Response) => {
     const data = await response.json()
+
+    if (!response.ok) {
+      const errorMessage = data.error?.message || 'Failed to update contact'
+      logger.error('Failed to update contact', { status: response.status, error: errorMessage })
+      throw new Error(errorMessage)
+    }
+
     const contact = transformPerson(data)
 
     return {
