add lazy init for stripe client, similar to s3

Author: waleedlatif1

apps/sim/lib/billing/core/billing.test.ts

@@ -28,6 +28,16 @@ vi.mock('@/lib/billing/core/usage', () => ({
   getUserUsageData: vi.fn(),
 }))
 
+vi.mock('../stripe-client', () => ({
+  getStripeClient: vi.fn().mockReturnValue(null),
+  requireStripeClient: vi.fn().mockImplementation(() => {
+    throw new Error(
+      'Stripe client is not available. Set STRIPE_SECRET_KEY in your environment variables.'
+    )
+  }),
+  hasValidStripeCredentials: vi.fn().mockReturnValue(false),
+}))
+
 describe('Billing Core Functions', () => {
   beforeEach(() => {
     vi.clearAllMocks()
@@ -144,26 +154,12 @@ describe('Billing Core Functions', () => {
     })
   })
 
-  describe('calculateUserOverage', () => {
-    // Skip these tests for now as they require complex async mocking
-    it.skip('calculates overage correctly for pro user', async () => {
-      // This test is skipped due to complex async mocking requirements
-      expect(true).toBe(true)
-    })
-
-    it.skip('returns zero overage when usage is below base price', async () => {
-      // This test is skipped due to complex async mocking requirements
-      expect(true).toBe(true)
-    })
-
-    it.skip('handles free plan users correctly', async () => {
-      // This test is skipped due to complex async mocking requirements
-      expect(true).toBe(true)
-    })
+  describe('Stripe client integration', () => {
+    it.concurrent('does not fail when Stripe credentials are not available', async () => {
+      const result = await getUsersAndOrganizationsForOverageBilling()
 
-    it.skip('returns null for non-existent user', async () => {
-      // This test is skipped due to complex async mocking requirements
-      expect(true).toBe(true)
+      expect(result).toHaveProperty('users')
+      expect(result).toHaveProperty('organizations')
     })
   })
 

apps/sim/lib/billing/core/billing.ts

@@ -1,19 +1,14 @@
 import { eq } from 'drizzle-orm'
-import Stripe from 'stripe'
-import { env } from '@/lib/env'
 import { createLogger } from '@/lib/logs/console-logger'
 import { db } from '@/db'
 import { member, organization, subscription, user, userStats } from '@/db/schema'
+import { requireStripeClient } from '../stripe-client'
 import { resetOrganizationBillingPeriod, resetUserBillingPeriod } from './billing-periods'
 import { getHighestPrioritySubscription } from './subscription'
 import { getUserUsageData } from './usage'
 
 const logger = createLogger('Billing')
 
-const stripeClient = new Stripe(env.STRIPE_SECRET_KEY || '', {
-  apiVersion: '2025-02-24.acacia',
-})
-
 interface BillingResult {
   success: boolean
   chargedAmount?: number
@@ -120,6 +115,7 @@ export async function createOverageBillingInvoice(
     }
 
     // Create invoice item for overage only
+    const stripeClient = requireStripeClient()
     const invoiceItem = await stripeClient.invoiceItems.create({
       customer: customerId,
       amount: Math.round(overageAmount * 100), // Convert to cents

apps/sim/lib/billing/stripe-client.ts

@@ -0,0 +1,60 @@
+import Stripe from 'stripe'
+import { env } from '@/lib/env'
+import { createLogger } from '@/lib/logs/console-logger'
+
+const logger = createLogger('StripeClient')
+
+// Lazily create a single Stripe client instance
+let _stripeClient: Stripe | null = null
+
+/**
+ * Check if Stripe credentials are valid
+ */
+export function hasValidStripeCredentials(): boolean {
+  return !!(
+    env.STRIPE_SECRET_KEY &&
+    env.STRIPE_SECRET_KEY.trim() !== '' &&
+    env.STRIPE_SECRET_KEY !== 'placeholder'
+  )
+}
+
+/**
+ * Get the Stripe client instance
+ * @returns Stripe client or null if credentials are not available
+ */
+export function getStripeClient(): Stripe | null {
+  if (_stripeClient) return _stripeClient
+
+  if (!hasValidStripeCredentials()) {
+    logger.warn('Stripe credentials not available - Stripe operations will be disabled')
+    return null
+  }
+
+  try {
+    _stripeClient = new Stripe(env.STRIPE_SECRET_KEY || '', {
+      apiVersion: '2025-02-24.acacia',
+    })
+
+    logger.info('Stripe client initialized successfully')
+    return _stripeClient
+  } catch (error) {
+    logger.error('Failed to initialize Stripe client', { error })
+    return null
+  }
+}
+
+/**
+ * Get the Stripe client instance, throwing an error if not available
+ * Use this when Stripe operations are required
+ */
+export function requireStripeClient(): Stripe {
+  const client = getStripeClient()
+
+  if (!client) {
+    throw new Error(
+      'Stripe client is not available. Set STRIPE_SECRET_KEY in your environment variables.'
+    )
+  }
+
+  return client
+}