ack PR comments

Author: waleed

apps/sim/app/api/guardrails/validate/route.ts

@@ -1,10 +1,10 @@
-import { NextRequest, NextResponse } from 'next/server'
-import { createLogger } from '@/lib/logs/console/logger'
-import { generateRequestId } from '@/lib/utils'
-import { validateJson } from '@/lib/guardrails/validate_json'
-import { validateRegex } from '@/lib/guardrails/validate_regex'
+import { type NextRequest, NextResponse } from 'next/server'
 import { validateHallucination } from '@/lib/guardrails/validate_hallucination'
+import { validateJson } from '@/lib/guardrails/validate_json'
 import { validatePII } from '@/lib/guardrails/validate_pii'
+import { validateRegex } from '@/lib/guardrails/validate_regex'
+import { createLogger } from '@/lib/logs/console/logger'
+import { generateRequestId } from '@/lib/utils'
 
 const logger = createLogger('GuardrailsValidateAPI')
 
@@ -14,7 +14,20 @@ export async function POST(request: NextRequest) {
 
   try {
     const body = await request.json()
-    const { validationType, input, regex, knowledgeBaseId, threshold, topK, model, apiKey, workflowId, piiEntityTypes, piiMode, piiLanguage } = body
+    const {
+      validationType,
+      input,
+      regex,
+      knowledgeBaseId,
+      threshold,
+      topK,
+      model,
+      apiKey,
+      workflowId,
+      piiEntityTypes,
+      piiMode,
+      piiLanguage,
+    } = body
 
     // Validate required fields
     if (!validationType) {
@@ -44,7 +57,12 @@ export async function POST(request: NextRequest) {
     }
 
     // Validate validationType
-    if (validationType !== 'json' && validationType !== 'regex' && validationType !== 'hallucination' && validationType !== 'pii') {
+    if (
+      validationType !== 'json' &&
+      validationType !== 'regex' &&
+      validationType !== 'hallucination' &&
+      validationType !== 'pii'
+    ) {
       return NextResponse.json({
         success: true,
         output: {
@@ -142,18 +160,19 @@ export async function POST(request: NextRequest) {
 }
 
 /**
- * Convert input to strfing for validation
+ * Convert input to string for validation
  */
 function convertInputToString(input: any): string {
   if (typeof input === 'string') {
     return input
-  } else if (input === null || input === undefined) {
+  }
+  if (input === null || input === undefined) {
     return ''
-  } else if (typeof input === 'object') {
+  }
+  if (typeof input === 'object') {
     return JSON.stringify(input)
-  } else {
-    return String(input)
   }
+  return String(input)
 }
 
 /**
@@ -184,15 +203,17 @@ async function executeValidation(
   // Use TypeScript validators for all validation types
   if (validationType === 'json') {
     return validateJson(inputStr)
-  } else if (validationType === 'regex') {
+  }
+  if (validationType === 'regex') {
     if (!regex) {
       return {
         passed: false,
         error: 'Regex pattern is required',
       }
     }
     return validateRegex(inputStr, regex)
-  } else if (validationType === 'hallucination') {
+  }
+  if (validationType === 'hallucination') {
     if (!knowledgeBaseId) {
       return {
         passed: false,
@@ -204,14 +225,15 @@ async function executeValidation(
     return await validateHallucination({
       userInput: inputStr,
       knowledgeBaseId,
-      threshold: threshold != null ? parseFloat(threshold) : 3, // Default threshold is 3 (confidence score, scores < 3 fail)
-      topK: topK ? parseInt(topK) : 10, // Default topK is 10
+      threshold: threshold != null ? Number.parseFloat(threshold) : 3, // Default threshold is 3 (confidence score, scores < 3 fail)
+      topK: topK ? Number.parseInt(topK) : 10, // Default topK is 10
       model: model,
       apiKey,
       workflowId,
       requestId,
     })
-  } else if (validationType === 'pii') {
+  }
+  if (validationType === 'pii') {
     // PII validation using Presidio
     return await validatePII({
       text: inputStr,
@@ -220,13 +242,9 @@ async function executeValidation(
       language: piiLanguage || 'en',
       requestId,
     })
-  } else {
-    return {
-      passed: false,
-      error: 'Unknown validation type',
-    }
+  }
+  return {
+    passed: false,
+    error: 'Unknown validation type',
   }
 }
-
-
-

apps/sim/lib/guardrails/validate_pii.ts

@@ -1,6 +1,6 @@
 import { spawn } from 'child_process'
-import path from 'path'
 import fs from 'fs'
+import path from 'path'
 import { createLogger } from '@/lib/logs/console/logger'
 
 const logger = createLogger('PIIValidator')
@@ -31,7 +31,7 @@ export interface PIIValidationResult {
 
 /**
  * Validate text for PII using Microsoft Presidio
- * 
+ *
  * Supports two modes:
  * - block: Fails validation if any PII is detected
  * - mask: Passes validation and returns masked text with PII replaced
@@ -97,11 +97,7 @@ async function executePythonPIIDetection(
 
     const timeout = setTimeout(() => {
       python.kill()
-      resolve({
-        passed: false,
-        error: 'PII validation timeout',
-        detectedEntities: [],
-      })
+      reject(new Error('PII validation timeout'))
     }, DEFAULT_TIMEOUT)
 
     // Write input to stdin as JSON
@@ -179,11 +175,11 @@ async function executePythonPIIDetection(
       logger.error(`[${requestId}] Failed to spawn Python process`, {
         error: error.message,
       })
-      resolve({
-        passed: false,
-        error: `Failed to execute Python: ${error.message}. Make sure Python 3 and Presidio are installed.`,
-        detectedEntities: [],
-      })
+      reject(
+        new Error(
+          `Failed to execute Python: ${error.message}. Make sure Python 3 and Presidio are installed.`
+        )
+      )
     })
   })
 }
@@ -206,18 +202,18 @@ export const SUPPORTED_PII_ENTITIES = {
   PHONE_NUMBER: 'Phone number',
   MEDICAL_LICENSE: 'Medical license number',
   URL: 'URL',
-  
+
   // USA
   US_BANK_NUMBER: 'US bank account number',
   US_DRIVER_LICENSE: 'US driver license',
   US_ITIN: 'US Individual Taxpayer Identification Number',
   US_PASSPORT: 'US passport number',
   US_SSN: 'US Social Security Number',
-  
+
   // UK
   UK_NHS: 'UK NHS number',
   UK_NINO: 'UK National Insurance Number',
-  
+
   // Other countries
   ES_NIF: 'Spanish NIF number',
   ES_NIE: 'Spanish NIE number',
@@ -244,4 +240,3 @@ export const SUPPORTED_PII_ENTITIES = {
 } as const
 
 export type PIIEntityType = keyof typeof SUPPORTED_PII_ENTITIES
-