Switch to enableNativeBignum = true when available (input-output-hk#1784)

* Switch to enableNativeBignum = true when available

* Fix bitvec dependency on gmp

Adds Bodigrim/bitvec#61

* Fix dynamic linking tests (now GMP is not always linked)

Co-authored-by: Tom McLaughlin <tom@codedown.io>

Author: hamishmack

modules/configuration-nix.nix

@@ -139,4 +139,9 @@ in {
   packages.ghc.flags.internal-interpreter = true;
   packages.ghci.flags.ghci = true;
   packages.ghci.flags.internal-interpreter = true;
+
+  # See https://github.com/Bodigrim/bitvec/pull/61
+  packages.bitvec.patches = [
+    (fromUntil "1.1.3.0" "1.1.3.0.1" ../patches/bitvec-gmp-fix.patch)
+  ];
 }

overlays/ghc.nix

@@ -5,7 +5,7 @@ final: prev: with prev;
     hasNativeBignum = name: !lib.hasPrefix "ghc8" name;
 
     ghcPkgOverrides = name: { enableIntegerSimple = false; } // lib.optionalAttrs (hasNativeBignum name) {
-      enableNativeBignum = false;
+      enableNativeBignum = true;
     };
 
     ghcDrvOverrides = drv: {

patches/bitvec-gmp-fix.patch

@@ -0,0 +1,33 @@
+From 903561107640cdbe1fbb3669c58e006d8b658fb8 Mon Sep 17 00:00:00 2001
+From: Mikaela Allan <mikaela@vitalbio.com>
+Date: Sun, 31 Jul 2022 11:52:27 -0400
+Subject: [PATCH] include Data.Bit.Gmp only if libgmp flag is set
+
+if this module is linked into the library when libgmp is not enabled,
+the foreign imports will lead to link failures when consuming the
+library.
+---
+ bitvec.cabal | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/bitvec.cabal b/bitvec.cabal
+index c6cb6c0..d4a28d6 100644
+--- a/bitvec.cabal
++++ b/bitvec.cabal
+@@ -78,7 +78,6 @@ library
+   other-modules:
+     Data.Bit.F2Poly
+     Data.Bit.F2PolyTS
+-    Data.Bit.Gmp
+     Data.Bit.Immutable
+     Data.Bit.ImmutableTS
+     Data.Bit.Internal
+@@ -98,6 +97,8 @@ library
+   if flag(libgmp)
+     extra-libraries: gmp
+     cpp-options: -DUseLibGmp
++    other-modules:
++      Data.Bit.Gmp
+ 
+ test-suite bitvec-tests
+   type: exitcode-stdio-1.0

test/cabal-22/default.nix

@@ -39,7 +39,7 @@ in recurseIntoAttrs {
     optionalString (!stdenv.hostPlatform.isAarch32 && !stdenv.hostPlatform.isAarch64) (''
       printf "checking that executable is dynamically linked to system libraries... " >& 2
     '' + optionalString (stdenv.isLinux && !stdenv.hostPlatform.isMusl) ''
-      ldd $exe | grep libgmp
+      ldd $exe | grep 'libc[.]so'
     '' + optionalString stdenv.isDarwin ''
       otool -L $exe | grep "libSystem.B"
     '' + ''

test/cabal-sublib/default.nix

@@ -47,7 +47,7 @@ in recurseIntoAttrs {
     optionalString (!stdenv.hostPlatform.isAarch32 && !stdenv.hostPlatform.isAarch64 && !stdenv.hostPlatform.isMusl) (''
       printf "checking that executable is dynamically linked to system libraries... " >& 2
     '' + optionalString (stdenv.isLinux && !stdenv.hostPlatform.isMusl) ''
-      ldd $exe | grep libgmp
+      ldd $exe | grep 'libc[.]so'
     '' + optionalString stdenv.isDarwin ''
       otool -L $exe |grep .dylib
     '') + ''

test/sublib-docs/default.nix

@@ -39,7 +39,7 @@ in recurseIntoAttrs {
     optionalString (!stdenv.hostPlatform.isAarch32 && !stdenv.hostPlatform.isAarch64 && !stdenv.hostPlatform.isMusl) (''
       printf "checking that executable is dynamically linked to system libraries... " >& 2
     '' + optionalString (stdenv.isLinux && !stdenv.hostPlatform.isMusl) ''
-      ldd $exe | grep libgmp
+      ldd $exe | grep 'libc[.]so'
     '' + optionalString stdenv.isDarwin ''
       otool -L $exe |grep .dylib
     '') + ''