prevent 'undefined index' warning

msalle · msalle · commit 82986f59bfeb · 2020-06-09T12:06:26.000+02:00
diff --git a/lib/PowerIdPDisco.php b/lib/PowerIdPDisco.php
@@ -296,13 +296,14 @@ public function handleRequest(): void
             }
         }
 
-        if (!is_null($t->data['faventry'])) {
+        if (isset($t->data['faventry'])) {
             $t->data['autofocus'] = 'favouritesubmit';
         }
 
         /* store the tab list in the session */
         $session = Session::getSessionFromRequest();
-        $session->setData('discopower:tabList', 'faventry', $t->data['faventry']);
+        if (array_key_exists('faventry', $t->data))
+            $session->setData('discopower:tabList', 'faventry', $t->data['faventry']);
         $session->setData('discopower:tabList', 'tabs', array_keys($idpList));
         $session->setData('discopower:tabList', 'defaulttab', $t->data['defaulttab']);
 

Original file line number	Diff line number	Diff line change
`@@ -296,13 +296,14 @@ public function handleRequest(): void`
`296`	`296`	`}`
`297`	`297`	`}`
`298`	`298`
`299`		`- if (!is_null($t->data['faventry'])) {`
	`299`	`+ if (isset($t->data['faventry'])) {`
`300`	`300`	`$t->data['autofocus'] = 'favouritesubmit';`
`301`	`301`	`}`
`302`	`302`
`303`	`303`	`/* store the tab list in the session */`
`304`	`304`	`$session = Session::getSessionFromRequest();`
`305`		`- $session->setData('discopower:tabList', 'faventry', $t->data['faventry']);`
	`305`	`+ if (array_key_exists('faventry', $t->data))`
	`306`	`+ $session->setData('discopower:tabList', 'faventry', $t->data['faventry']);`
`306`	`307`	`$session->setData('discopower:tabList', 'tabs', array_keys($idpList));`
`307`	`308`	`$session->setData('discopower:tabList', 'defaulttab', $t->data['defaulttab']);`
`308`	`309`