Make the defaultweight static

The uasort function is static, and needs a static config variable :(

Author: ghalse

lib/PowerIdPDisco.php

@@ -44,6 +44,13 @@ class PowerIdPDisco extends \SimpleSAML\XHTML\IdPDisco
     private $cdcLifetime;
 
 
+    /**
+     * The default sort weight for entries without 'discopower.weight'.
+     *
+     * @var int|null
+     */
+     static $defaultWeight = 50;
+
     /**
      * Initializes this discovery service.
      *
@@ -65,6 +72,8 @@ public function __construct(array $metadataSets, string $instance)
         }
 
         $this->cdcLifetime = $this->discoconfig->getInteger('cdc.lifetime', null);
+
+        self::$defaultWeight = $this->discoconfig->getInteger('defaultweight', 50);
     }
 
 
@@ -99,10 +108,10 @@ public static function mcmp(array $a, array $b): int
     {
         // default weights
         if (!isset($a['discopower.weight']) || !is_int($a['discopower.weight'])) {
-            $a['discopower.weight'] = $this->discoconfig->getInteger('defaultweight', 50);
+            $a['discopower.weight'] = self::$defaultWeight;
         }
         if (!isset($b['discopower.weight']) || !is_int($b['discopower.weight'])) {
-            $b['discopower.weight'] = $this->discoconfig->getInteger('defaultweight', 50);
+            $b['discopower.weight'] = self::$defaultWeight;
         }
         if ($a['discopower.weight'] > $b['discopower.weight']) {
             return -1; // higher weights further up